[android_webview] Fix GetTitleTest.testGetTitleWithWriteln

[android_webview] GetTitleTest.testGetTitleWithWriteln -> ...testGetTitleSetFromJS

First, turning on JS, which is disabled by default.

Also, no one guarantees that onload + writeln + onPageFinished must work as
you'd expect, so there is no point in testing this scenario. So just change this
test to verify that the title updated via JS is reported by GetTitle.

BUG=151012
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243537

[boliu, 2014-01-07 16:56:59]

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java
(right):

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java:157:
"<script>document.writeln(document.title=\"" + expectedTitle + "\")</script>" +
I just looked up that writeln takes a string. Looking at this, I think this is
passing the result of the assignment, but the title is set by the assignment,
not the writeln call?

So, what exactly was this test testing? Should we just remove it?

[mnaganov (inactive), 2014-01-07 17:17:07]

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java
(right):

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java:157:
"<script>document.writeln(document.title=\"" + expectedTitle + "\")</script>" +
On 2014/01/07 16:57:00, boliu wrote:
> I just looked up that writeln takes a string. Looking at this, I think this is
> passing the result of the assignment, but the title is set by the assignment,
> not the writeln call?
> 
> So, what exactly was this test testing? Should we just remove it?

The original issue was that we had a test that, in onload handler, was
simultaneously setting document title to some value and was writing the value
into the document, and that test stopped working at some point, and I fixed it
by removing the writeln call.

So it looks like the combination of onload + writeln + onpagefinished still
doesn't work, but no one guarantees that it should, so there is no point in
fixing this.

However, setting the title from JS and reading it back from getTitle should be
working, and we have no other tests in this suite that verify this. So, I think,
we should remove the call to 'document.writeln' and rename the test to
'testGetTitleSetByJS', then it will make sense.

[boliu, 2014-01-07 17:21:39]

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
File
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java
(right):

https://codereview.chromium.org/117993005/diff/1/android_webview/javatests/sr...
android_webview/javatests/src/org/chromium/android_webview/test/GetTitleTest.java:157:
"<script>document.writeln(document.title=\"" + expectedTitle + "\")</script>" +
On 2014/01/07 17:17:07, Mikhail Naganov (Cr) wrote:
> On 2014/01/07 16:57:00, boliu wrote:
> > I just looked up that writeln takes a string. Looking at this, I think this
is
> > passing the result of the assignment, but the title is set by the
assignment,
> > not the writeln call?
> > 
> > So, what exactly was this test testing? Should we just remove it?
> 
> The original issue was that we had a test that, in onload handler, was
> simultaneously setting document title to some value and was writing the value
> into the document, and that test stopped working at some point, and I fixed it
> by removing the writeln call.
> 
> So it looks like the combination of onload + writeln + onpagefinished still
> doesn't work, but no one guarantees that it should, so there is no point in
> fixing this.
> 
> However, setting the title from JS and reading it back from getTitle should be
> working, and we have no other tests in this suite that verify this. So, I
think,
> we should remove the call to 'document.writeln' and rename the test to
> 'testGetTitleSetByJS', then it will make sense.

sgtm

[mnaganov (inactive), 2014-01-07 17:49:20]

Thanks, Bo! PTAL.

[boliu, 2014-01-07 17:57:51]

lgtm

Don't forget to update the CL description

[commit-bot: I haz the power, 2014-01-08 09:28:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnaganov@chromium.org/117993005/110001

[commit-bot: I haz the power, 2014-01-08 12:39:15]

Change committed as 243537