Issue 1179923004: Fix data loading in the stocks app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179923004: Fix data loading in the stocks app (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix data loading in the stocks app We can't have two copies of |embedder.dart| or |shell.dart| because they take ownership of some underlying Mojo handles. Instead of duplicating the code, this CL makes the old locations just export all the symbols from the new location. I've also done the same with fetch.dart to avoid code duplication. Finally, I've removed image_cache.dart in the old location because the only clients already live in the new world and ought to use the new location. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/f07a899b50995c618a0131a76064e0b43c82c27f

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+8 lines, -186 lines)			Patch
M	sky/examples/raw/spinning_image.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/examples/rendering/interactive_flex.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/BUILD.gn	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/sdk/lib/framework/embedder.dart	View	1 chunk	+2 lines, -68 lines	0 comments	Download
M	sky/sdk/lib/framework/net/fetch.dart	View	1 chunk	+2 lines, -48 lines	0 comments	Download
D	sky/sdk/lib/framework/net/image_cache.dart	View	1 chunk	+0 lines, -44 lines	0 comments	Download
M	sky/sdk/lib/framework/shell.dart	View	1 chunk	+2 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

Committed patchset #1 (id:1) manually as f07a899b50995c618a0131a76064e0b43c82c27f (presubmit successful).

5 years, 6 months ago (2015-06-18 16:14:55 UTC) #2

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages