Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 1179923002: In %TypedArray%.from, use InternalArray rather than GlobalArray (Closed)

Created:
5 years, 6 months ago by dehrenberg
Modified:
5 years, 6 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

In %TypedArray%.from, use InternalArray rather than GlobalArray This patch holds intermediate results from %TypedArray%.from in an InternalArray. The change should help TypedArray behavior not be altered by changes to Array or Array.prototype. However, I can't think of a test case where it's actually visible, so I haven't added any tests in this patch. BUG=v8:4128 R=adamk LOG=y

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/harmony-typedarray.js View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Dan Ehrenberg
5 years, 6 months ago (2015-06-11 17:18:10 UTC) #2
adamk
Given what's going on in the other patch, this will be strictly slower, as you'll ...
5 years, 6 months ago (2015-06-11 17:36:33 UTC) #3
arv (Not doing code reviews)
5 years, 6 months ago (2015-06-11 17:39:40 UTC) #4
On 2015/06/11 17:36:33, adamk wrote:
> Given what's going on in the other patch, this will be strictly slower, as
> you'll miss the fast path for the Array constructor.
> 
> I don't think this is really worth it, since it has no effect on the behavior
> (and we'll have tests already that Array.from doesn't look at the prototype of
> the object it works on).

I agree. Sorry for causing extra work here.

Powered by Google App Engine
This is Rietveld 408576698