Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 1179913002: Fix up constructor naming style for MaskFilter and ColorFilter. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix up constructor naming style for MaskFilter and ColorFilter. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/8932cdb8b11b2a1525c7278c4c396574d8bdfec3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M sky/engine/core/painting/ColorFilter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/painting/MaskFilter.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/game/lib/sprite.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/painting.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/examples/raw/shadow.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/painting/shadows.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Matt Perry
5 years, 6 months ago (2015-06-11 16:56:45 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 17:00:47 UTC) #3
Matt Perry
5 years, 6 months ago (2015-06-11 17:15:24 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8932cdb8b11b2a1525c7278c4c396574d8bdfec3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698