Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 1179873005: [AppRemoting] Break out AppRemoting shared module (re-land). (Closed)

Created:
5 years, 6 months ago by garykac
Modified:
5 years, 6 months ago
Reviewers:
Lei Zhang, kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[AppRemoting] Break out AppRemoting shared module. This is a reland of crrev.com/1176143002 with missing files added: remoting/webapp/app_remoting/shared_module/manifest.json This cl breaks out the shared AppRemoting code into a shared module so that it does not need to be duplicated in each individual app. This version has the following limitations which will be addressed in follow-up cls: (1) The apps have a hard-coded reference to the dev shared module (2) The apps have a hard-coded reference to the dev orchestrator (3) The resources in the app stub should be replaced with empty stub resources rather than a copy of all the shared resources. (4) The shared module is only built in GN (not GYP) BUG= Committed: https://crrev.com/5b696cf0d943d03a7bd388bdca1ffc6d95d3fc9c Cr-Commit-Position: refs/heads/master@{#334708}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+431 lines, -200 lines) Patch
M remoting/app_remoting_webapp.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/app_remoting_webapp_build.gypi View 3 chunks +21 lines, -11 lines 0 comments Download
M remoting/app_remoting_webapp_files.gypi View 3 chunks +15 lines, -6 lines 0 comments Download
M remoting/remoting_options.gni View 1 chunk +3 lines, -0 lines 0 comments Download
M remoting/remoting_webapp_files.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/webapp/BUILD.gn View 2 chunks +16 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/html/context_menu.html View 1 chunk +1 line, -1 line 0 comments Download
A + remoting/webapp/app_remoting/html/template_background.html View 1 2 chunks +2 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/html/template_feedback_consent.html View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/app_remoting/html/template_lg.html View 2 chunks +3 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/html/template_loading_window.html View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting.js View 1 chunk +40 lines, -6 lines 0 comments Download
M remoting/webapp/app_remoting/js/app_remoting_activity.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/app_remoting/js/application_context_menu.js View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/app_remoting/js/ar_background.js View 1 chunk +4 lines, -1 line 0 comments Download
D remoting/webapp/app_remoting/js/ar_main.js View 1 chunk +0 lines, -18 lines 0 comments Download
M remoting/webapp/app_remoting/js/feedback_consent.js View 3 chunks +7 lines, -1 line 0 comments Download
M remoting/webapp/app_remoting/manifest_common.json.jinja2 View 2 chunks +6 lines, -2 lines 0 comments Download
A remoting/webapp/app_remoting/shared_module/manifest.json View 1 chunk +8 lines, -0 lines 0 comments Download
A remoting/webapp/app_remoting/vendor/arv_background.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
A remoting/webapp/app_remoting/vendor/arv_main.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A + remoting/webapp/app_remoting/vendor/arv_main.js View 1 1 chunk +8 lines, -1 line 0 comments Download
A remoting/webapp/app_remoting/vendor/arv_wcs_sandbox.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
D remoting/webapp/base/js/app_capabilities.js View 1 chunk +0 lines, -18 lines 0 comments Download
M remoting/webapp/base/js/application.js View 2 chunks +10 lines, -0 lines 0 comments Download
M remoting/webapp/base/js/message_window_helper.js View 2 chunks +12 lines, -1 line 0 comments Download
M remoting/webapp/base/js/plugin_settings.js View 1 chunk +0 lines, -12 lines 0 comments Download
M remoting/webapp/build-webapp.py View 8 chunks +66 lines, -46 lines 0 comments Download
M remoting/webapp/build_template.gni View 9 chunks +157 lines, -57 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting.js View 1 chunk +9 lines, -0 lines 0 comments Download
M remoting/webapp/crd/js/desktop_remoting_activity.js View 1 chunk +1 line, -1 line 0 comments Download
M remoting/webapp/files.gni View 4 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
garykac
This is identical to the previous cl with the missing files added.
5 years, 6 months ago (2015-06-16 19:03:14 UTC) #2
kelvinp
lgtm
5 years, 6 months ago (2015-06-16 21:00:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179873005/20001
5 years, 6 months ago (2015-06-16 21:18:44 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 21:53:35 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5b696cf0d943d03a7bd388bdca1ffc6d95d3fc9c Cr-Commit-Position: refs/heads/master@{#334708}
5 years, 6 months ago (2015-06-16 21:54:41 UTC) #7
Lei Zhang
I think this broke the GN build: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/builds/1308 but strangely, the sheriffs did not revert ...
5 years, 6 months ago (2015-06-17 06:15:55 UTC) #9
phoglund_chromium
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1191883002/ by phoglund@chromium.org. ...
5 years, 6 months ago (2015-06-17 08:42:57 UTC) #10
phoglund_chromium
5 years, 6 months ago (2015-06-17 08:45:28 UTC) #11
Message was sent while issue was closed.
On 2015/06/17 06:15:55, Lei Zhang wrote:
> I think this broke the GN build:
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20Clobber/buil...
> but strangely, the sheriffs did not revert it.

Lei: I'm trying to revert it now to see if that fixes the problem.

Powered by Google App Engine
This is Rietveld 408576698