Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1179873003: Serializer: support all alignment kinds. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 1 month ago
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: support all alignment kinds. We use an alignment prefix for unusual alignment kinds (not kWordAligned). This will cause new objects to be aligned in ReadObject, and back references to be aligned to skip padding. The motivation to change the undefined next sentinel in WeakCell is this: When the deserializer aligns an object, it requires filler maps to already exist to create filler objects as padding. However, deserializing the filler map leads to deserializing NaN, which as heap number is aligned: filler map > meta map > weak cell cache > undefined > NaN If we use the-hole instead of undefined as sentinel, it works. R=jochen@chromium.org,bbudge@chromium.org BUG=v8:4178 LOG=N Committed: https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6 Cr-Commit-Position: refs/heads/master@{#29044} Committed: https://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6 Cr-Commit-Position: refs/heads/master@{#29047}

Patch Set 1 #

Patch Set 2 : add assertion #

Patch Set 3 : fix assertion #

Patch Set 4 : fix assertion conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -76 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 2 chunks +5 lines, -6 lines 0 comments Download
M src/heap/mark-compact.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/snapshot/serialize.h View 5 chunks +18 lines, -6 lines 0 comments Download
M src/snapshot/serialize.cc View 1 10 chunks +71 lines, -57 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Yang
5 years, 6 months ago (2015-06-16 08:31:59 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-16 08:33:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179873003/20001
5 years, 6 months ago (2015-06-16 08:39:57 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5739)
5 years, 6 months ago (2015-06-16 09:07:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179873003/40001
5 years, 6 months ago (2015-06-16 09:24:01 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-16 09:46:02 UTC) #11
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2146ab75387d47eef6582bd8c2d0cfc6c42b68b6 Cr-Commit-Position: refs/heads/master@{#29044}
5 years, 6 months ago (2015-06-16 09:46:20 UTC) #12
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1173253006/ by machenbach@chromium.org. ...
5 years, 6 months ago (2015-06-16 10:18:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179873003/60001
5 years, 6 months ago (2015-06-16 10:41:26 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-16 11:04:19 UTC) #17
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 11:04:31 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/63f4c751625e6d9948ef2276ebacdd7fc7d916a6
Cr-Commit-Position: refs/heads/master@{#29047}

Powered by Google App Engine
This is Rietveld 408576698