Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 11798003: Move NavigationPolicyToDisposition() function into render_view_impl.cc (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, Ben Goodger (Google)
Visibility:
Public.

Description

Move NavigationPolicyToDisposition() function into render_view_impl.cc Since it's only used there. That way we will be able to move window_open_disposition.h out of webkit/ BUG=146251 R=jam@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175629

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -38 lines) Patch
M content/renderer/render_view_impl.cc View 1 2 chunks +24 lines, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/window_open_disposition.h View 2 chunks +0 lines, -7 lines 0 comments Download
D webkit/glue/window_open_disposition.cc View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tfarina
7 years, 11 months ago (2013-01-07 21:21:52 UTC) #1
jam
lgtm with nit https://codereview.chromium.org/11798003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/11798003/diff/1/content/renderer/render_view_impl.cc#newcode343 content/renderer/render_view_impl.cc:343: namespace { nit: in general, all ...
7 years, 11 months ago (2013-01-08 16:32:32 UTC) #2
tfarina
https://codereview.chromium.org/11798003/diff/1/content/renderer/render_view_impl.cc File content/renderer/render_view_impl.cc (right): https://codereview.chromium.org/11798003/diff/1/content/renderer/render_view_impl.cc#newcode343 content/renderer/render_view_impl.cc:343: namespace { On 2013/01/08 16:32:32, John Abd-El-Malek wrote: > ...
7 years, 11 months ago (2013-01-08 20:42:18 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 20:42:39 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698