Issue 1179763009: Give ParentDataNodes snappier names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179763009: Give ParentDataNodes snappier names (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Give ParentDataNodes snappier names FlexExpandingChild -> Flexible StackPositionedChild -> Positioned Also, name the child argument |child| for consistency. TBR=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/d95a8737bff6f78a2901da13a27ff3de01abc9c4

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -23 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_menu.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/examples/stocks2/lib/stock_row.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/examples/widgets/container.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/examples/widgets/spinning_mixed.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/basic.dart	View		2 chunks	+10 lines, -6 lines	0 comments	Download
M	sky/sdk/lib/widgets/drawer_header.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/widgets/menu_item.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sky/sdk/lib/widgets/tool_bar.dart	View		1 chunk	+8 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

Committed patchset #2 (id:20001) manually as d95a8737bff6f78a2901da13a27ff3de01abc9c4 (presubmit successful).

5 years, 6 months ago (2015-06-16 04:03:33 UTC) #2

Message was sent while issue was closed.

lgtm