Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1500)

Unified Diff: Source/platform/heap/Heap.cpp

Issue 1179763005: Oilpan: Fix compile of GC_PROFILING build, and remove object graph dumper. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add EagerSweepHeap. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/Heap.cpp
diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp
index 1d8b513d344e1d1ce50f915b595650f97d559afb..0adea02c3daaa03841489548be8fbe938a071c22 100644
--- a/Source/platform/heap/Heap.cpp
+++ b/Source/platform/heap/Heap.cpp
@@ -1427,9 +1427,6 @@ void NormalPage::checkAndMarkPointer(Visitor* visitor, Address address)
HeapObjectHeader* header = findHeaderFromAddress(address);
if (!header || header->isDead())
return;
-#if ENABLE(GC_PROFILING)
- visitor->setHostInfo(&address, "stack");
-#endif
markPointer(visitor, header);
}
@@ -1612,9 +1609,6 @@ void LargeObjectPage::checkAndMarkPointer(Visitor* visitor, Address address)
ASSERT(contains(address));
if (!containedInObjectPayload(address) || heapObjectHeader()->isDead())
return;
-#if ENABLE(GC_PROFILING)
- visitor->setHostInfo(&address, "stack");
-#endif
markPointer(visitor, heapObjectHeader());
}
@@ -1841,12 +1835,6 @@ const GCInfo* Heap::findGCInfo(Address address)
#endif
#if ENABLE(GC_PROFILING)
-void Heap::dumpPathToObjectOnNextGC(void* p)
-{
- MarkingVisitor<Visitor::GlobalMarking> visitor;
- visitor->dumpPathToObjectOnNextGC(p);
-}
-
String Heap::createBacktraceString()
{
int framesToShow = 3;
@@ -1898,10 +1886,6 @@ bool Heap::popAndInvokeTraceCallback(Visitor* visitor)
CallbackStack::Item* item = s_markingStack->pop();
if (!item)
return false;
-
-#if ENABLE(GC_PROFILING)
- visitor->setHostInfo(item->object(), classOf(item->object()));
-#endif
item->call(visitor);
return true;
}
@@ -2025,9 +2009,6 @@ void Heap::collectGarbage(ThreadState::StackState stackState, ThreadState::GCTyp
"gcReason", gcReasonString(reason));
TRACE_EVENT_SCOPED_SAMPLING_STATE("blink_gc", "BlinkGC");
double timeStamp = WTF::currentTimeMS();
-#if ENABLE(GC_PROFILING)
- gcScope.visitor()->objectGraph().clear();
-#endif
// Disallow allocation during garbage collection (but not during the
// finalization that happens when the gcScope is torn down).
@@ -2060,10 +2041,6 @@ void Heap::collectGarbage(ThreadState::StackState stackState, ThreadState::GCTyp
postGC(gcType);
-#if ENABLE(GC_PROFILING)
- gcScope.visitor()->reportStats();
-#endif
-
double markingTimeInMilliseconds = WTF::currentTimeMS() - timeStamp;
s_estimatedMarkingTimePerByte = totalObjectSize ? (markingTimeInMilliseconds / 1000 / totalObjectSize) : 0;
« no previous file with comments | « Source/platform/heap/Handle.h ('k') | Source/platform/heap/HeapTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698