Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(19)

Issue 1179763005: Oilpan: Fix compile of GC_PROFILING build, and remove object graph dumper. (Closed)

Created:
4 years, 10 months ago by Yuta Kitamura
Modified:
4 years, 10 months ago
Reviewers:
haraken, oilpan-reviews
CC:
blink-reviews, haraken, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Fix compile of GC_PROFILING build, and remove object graph dumper. This patch removes the ability to dump object graphs, since it seems like nobody is using it. The code does not compile anyway, and we can pull it back whenever it becomes necessary in the future. This patch also fixes a few places breaking compile of GC_PROFILING builds. BUG=none R=haraken@chromium.org, oilpan-reviews@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196996

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add EagerSweepHeap. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -178 lines) Patch
M Source/platform/heap/Handle.h View 3 chunks +0 lines, -9 lines 0 comments Download
M Source/platform/heap/Heap.cpp View 6 chunks +0 lines, -23 lines 0 comments Download
M Source/platform/heap/HeapTest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/platform/heap/InlinedGlobalMarkingVisitor.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/heap/MarkingVisitor.h View 2 chunks +0 lines, -115 lines 0 comments Download
M Source/platform/heap/MarkingVisitorImpl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/platform/heap/ThreadState.cpp View 1 2 chunks +14 lines, -3 lines 0 comments Download
M Source/platform/heap/Visitor.h View 2 chunks +0 lines, -14 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yuta Kitamura
PTAL; locally tested that GC_PROFILING build compiles.
4 years, 10 months ago (2015-06-11 10:46:14 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179763005/1
4 years, 10 months ago (2015-06-11 10:46:52 UTC) #3
haraken
LGTM The code hasn't been used for a long time, so I'm ok to remove. ...
4 years, 10 months ago (2015-06-11 10:55:33 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_blink_oilpan_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_oilpan_dbg/builds/1817)
4 years, 10 months ago (2015-06-11 12:55:32 UTC) #6
Yuta Kitamura
https://codereview.chromium.org/1179763005/diff/1/Source/platform/heap/ThreadState.cpp File Source/platform/heap/ThreadState.cpp (right): https://codereview.chromium.org/1179763005/diff/1/Source/platform/heap/ThreadState.cpp#newcode418 Source/platform/heap/ThreadState.cpp:418: SNAPSHOT_HEAP(NormalPage1); On 2015/06/11 10:55:32, haraken wrote: > > You ...
4 years, 10 months ago (2015-06-12 02:43:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179763005/20001
4 years, 10 months ago (2015-06-12 02:43:45 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2015-06-12 04:05:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196996

Powered by Google App Engine
This is Rietveld 408576698