Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1179763003: X87: Disable the test case for X87 since ea2cb139d. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
conradw, danno, rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Disable the test case for X87 since ea2cb139d. The strong-object-set-proto test cases will throw one expected exception and the exception message should include the source position in the JS file. But crankshaft compiler does not generate the source position for it when creating the flow graph by default. The source position information is always zero. So it failed when comparing with the reference file. If we use crankshaft compiler on IA32 platform to run this test case, it has the same failure. we will open these test case for x87 once turbofan for X87 is enabled. BUG= Committed: https://crrev.com/8c57b2e16d11af541a64ef876ff2133cdd444233 Cr-Commit-Position: refs/heads/master@{#29003}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M test/message/message.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
chunyang.dai
PTAL.
5 years, 6 months ago (2015-06-11 09:29:56 UTC) #2
conradw
LGTM Before committing, maybe change the description of this issue to refer to the new ...
5 years, 6 months ago (2015-06-11 10:27:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179763003/1
5 years, 6 months ago (2015-06-11 14:50:24 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 6 months ago (2015-06-11 14:50:26 UTC) #7
chunyang.dai
Danno. PTAL. thanks
5 years, 6 months ago (2015-06-11 15:01:46 UTC) #9
conradw
On 2015/06/11 15:01:46, chunyang.dai wrote: > Danno. > > PTAL. > > thanks I wondered ...
5 years, 6 months ago (2015-06-11 15:03:55 UTC) #10
rossberg
lgtm
5 years, 6 months ago (2015-06-12 10:00:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179763003/1
5 years, 6 months ago (2015-06-12 14:56:33 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 15:22:35 UTC) #15
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 15:22:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c57b2e16d11af541a64ef876ff2133cdd444233
Cr-Commit-Position: refs/heads/master@{#29003}

Powered by Google App Engine
This is Rietveld 408576698