Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1179733009: Always enable Oilpan for EventSource. (Closed)

Created:
5 years, 6 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, vivekg_samsung, eae+blinkwatch, eric.carlson_apple.com, vivekg, apavlov+blink_chromium.org, caseq+blink_chromium.org, arv+blink, blink-reviews-events_chromium.org, yhirano+watch_chromium.org, tzik, yurys+blink_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, devtools-reviews_chromium.org, philipj_slow, lushnikov+blink_chromium.org, feature-media-reviews_chromium.org, nhiroki, Nate Chapin, tyoshino+watch_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org, Inactive, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Always enable Oilpan for EventSource. This puts EventSource objects on the Oilpan heap by default. Doing so necessitated the removal of WTF_MAKE_FAST_ALLOCATED() for ThreadableLoaderClient; done here, along with moving that annotation to its derived classes where possible. R=haraken BUG=497595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198217

Patch Set 1 #

Patch Set 2 : rebased + fix worker shutdown #

Patch Set 3 : reduce footprint #

Patch Set 4 : msvc compile fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -39 lines) Patch
M Source/core/fileapi/FileReader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.h View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/fileapi/FileReaderSync.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/ThreadableLoaderClient.h View 1 2 1 chunk +21 lines, -22 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridge.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/loader/WorkerLoaderClientBridgeSyncHelper.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/page/EventSource.h View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/page/EventSource.cpp View 1 4 chunks +11 lines, -5 lines 0 comments Download
M Source/core/page/EventSource.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/fetch/Body.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/mediasource/SourceBuffer.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
please take a look.
5 years, 5 months ago (2015-07-02 13:12:48 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-02 13:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179733009/40002
5 years, 5 months ago (2015-07-02 14:35:04 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-02 14:38:05 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:40002) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198217

Powered by Google App Engine
This is Rietveld 408576698