Issue 1179733006: bluetooth: Comment out a test to change behavior on browser side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179733006: bluetooth: Comment out a test to change behavior on browser side. (Closed)

Created:
4 years, 10 months ago by ortuno

Modified:
4 years, 10 months ago

Reviewers:
scheib

CC:
blink-reviews, scheib+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@bluetooth-add-errors

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

bluetooth: Comment out a test to change behavior on browser side. The test is commented out because the follow up patch changes the error returned when trying to read an unreadable characteristic. This is the first patch to add more descriptive error messages and to return different errors based on the GATT Error: [1] This patch. [2] http://crrev.com/1177613002 [3] http://crrev.com/1164393004 BUG=490419, 499542 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197092

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	LayoutTests/bluetooth/readValue.html	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 7 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179733006/20001

4 years, 10 months ago (2015-06-13 21:12:14 UTC) #6

commit-bot: I haz the power

4 years, 10 months ago (2015-06-13 22:01:52 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197092