Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 1179733005: Update mojo sdk to rev bdbb0c7e396fc4044a8b194058d7a7e529715286 (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update mojo sdk to rev bdbb0c7e396fc4044a8b194058d7a7e529715286 Adds flag to build/module_args/mojo.gni to turn off SDK network service. Updates callsites of mojo::embedder::CreateChannel to remove an argument. BUG=None TBR=ben@chromium.org Committed: https://crrev.com/3b2e73c9e794a80a6ae44b4b953d7df477fb66c2 Cr-Commit-Position: refs/heads/master@{#334204}

Patch Set 1 #

Patch Set 2 : +gyp #

Patch Set 3 : #

Patch Set 4 : cherry-pick https://codereview.chromium.org/1180993002/ from upstream #

Patch Set 5 : exclude ipc support tests on iOS where theres no multiprocess #

Patch Set 6 : ...but don't exclude them everywhere >< #

Patch Set 7 : fix CreateChannel usage #

Patch Set 8 : update CommandBufferImpl (Binding::OnConnectionError is no more) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1648 lines, -715 lines) Patch
M build/module_args/mojo.gni View 1 chunk +2 lines, -1 line 0 comments Download
M components/view_manager/gles2/command_buffer_impl.cc View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M content/common/mojo/channel_init.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/runner/child_process.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/runner/child_process_host.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/mojo_edk_system_impl.gypi View 1 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.h View 5 chunks +39 lines, -29 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder.cc View 9 chunks +88 lines, -139 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_internal.h View 3 chunks +7 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/embedder_unittest.cc View 10 chunks +81 lines, -57 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/master_process_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/process_type.h View 2 chunks +11 lines, -0 lines 0 comments Download
A + third_party/mojo/src/mojo/edk/embedder/slave_info.h View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/test_embedder.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/system/BUILD.gn View 4 chunks +5 lines, -2 lines 0 comments Download
A third_party/mojo/src/mojo/edk/system/channel_id.h View 1 chunk +23 lines, -0 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/channel_info.h View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/mojo/src/mojo/edk/system/channel_info.cc View 1 chunk +0 lines, -34 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.h View 5 chunks +11 lines, -24 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager.cc View 7 chunks +26 lines, -39 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/channel_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/connection_manager_unittest.cc View 11 chunks +39 lines, -49 lines 0 comments Download
A third_party/mojo/src/mojo/edk/system/ipc_support.h View 1 chunk +181 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/edk/system/ipc_support.cc View 1 chunk +165 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/edk/system/ipc_support_unittest.cc View 1 chunk +342 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.h View 2 chunks +10 lines, -14 lines 0 comments Download
M third_party/mojo/src/mojo/edk/system/master_connection_manager.cc View 2 chunks +16 lines, -17 lines 0 comments Download
A third_party/mojo/src/mojo/edk/system/process_identifier.h View 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/VERSION View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/binding.h View 1 2 3 7 chunks +20 lines, -11 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/interface_ptr.h View 1 2 3 4 chunks +19 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/connector.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/interface_ptr_internal.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/lib/router.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/strong_binding.h View 1 2 3 4 chunks +19 lines, -9 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/binding_unittest.cc View 2 chunks +5 lines, -18 lines 0 comments Download
M third_party/mojo/src/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc View 10 chunks +12 lines, -28 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/BUILD.gn View 3 chunks +7 lines, -2 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/CHANGELOG.md View 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/lib/application.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/lib/bindings.dart View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/lib/src/codec.dart View 3 chunks +27 lines, -0 lines 0 comments Download
A third_party/mojo/src/mojo/public/dart/lib/src/union.dart View 1 chunk +24 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/pubspec.yaml View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/dart/rules.gni View 5 chunks +24 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/application/application_impl.go View 5 chunks +5 lines, -5 lines 0 comments Download
M third_party/mojo/src/mojo/public/go/application/connection.go View 4 chunks +5 lines, -5 lines 0 comments Download
A + third_party/mojo/src/mojo/public/interfaces/BUILD.gn View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Connector.java View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Encoder.java View 2 chunks +6 lines, -10 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/Interface.java View 5 chunks +24 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/java/bindings/src/org/chromium/mojo/bindings/InterfaceRequest.java View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/mojo.gni View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/NETWORK_SERVICE_VERSION View 1 chunk +1 line, -1 line 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/encoding_macros.tmpl View 1 chunk +88 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module.lib.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/module_definition.tmpl View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/struct_definition.tmpl View 3 chunks +3 lines, -74 lines 0 comments Download
A third_party/mojo/src/mojo/public/tools/bindings/generators/dart_templates/union_definition.tmpl View 1 chunk +109 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/go_templates/interface.tmpl View 6 chunks +27 lines, -27 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_dart_generator.py View 7 chunks +20 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/generators/mojom_go_generator.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/mojom.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/data.py View 2 chunks +15 lines, -7 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom/generate/module.py View 5 chunks +15 lines, -3 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/bindings/pylib/mojom_tests/generate/data_unittest.py View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_list_mojoms.py View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/public/tools/dart_pkg.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ken Rockot(use gerrit already)
sky@ could you please take a look at my change to CommandBufferImpl and verify that ...
5 years, 6 months ago (2015-06-12 16:56:51 UTC) #2
Ken Rockot(use gerrit already)
Ah I see you're OOO. Given that I'm fairly confident my change is OK and ...
5 years, 6 months ago (2015-06-12 17:41:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179733005/130001
5 years, 6 months ago (2015-06-12 17:42:11 UTC) #5
commit-bot: I haz the power
Committed patchset #8 (id:130001)
5 years, 6 months ago (2015-06-12 18:40:16 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 18:41:13 UTC) #7
Message was sent while issue was closed.
Patchset 8 (id:??) landed as
https://crrev.com/3b2e73c9e794a80a6ae44b4b953d7df477fb66c2
Cr-Commit-Position: refs/heads/master@{#334204}

Powered by Google App Engine
This is Rietveld 408576698