Material and RaisedButton.

Material and RaisedButton.

Make Material actually create material, with opinions about what that
means.

Make FloatingActionButton use this.

Make Scrollable use this.

Make BoxDecoration support drawing a circle instead of a rectangle, so
that floating action button doesn't need a custom painter.

Implement RaisedButton (and remove button.dart, since there's no
"button" in Material Design).

Make InkWell have a "child" argument instead of "children", and not
have it introduce a Flex into the hierarchy.

Update container.dart example. Clean up some imports.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f505c9c0f781a59a73d9c54ccb0014c2f6472e71

[Hixie, 2015-06-12 00:37:46]

One thing that's broken with this is that the + on the fab is the wrong size. I
guess it's because we're no longer using a flex to position the contents. I
should figure out how to fix that without having to use flex.

[Hixie, 2015-06-12 00:38:43]

I may also have broken the drawer. Will check on that tomorrow.

[abarth-chromium, 2015-06-12 03:08:04]

abarth@chromium.org changed reviewers:
+ abarth@chromium.org

[abarth-chromium, 2015-06-12 03:08:05]

LGTM

Very nice.  You forgot to git add edge.dart

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
File sky/sdk/lib/framework/widgets/raised_button.dart (right):

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:43: )
We could have a RenderObject that did:

new Foo(child: child, horizontal: 0.5, vertical: 0.5)

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:46: level: highlight ? 2 : 1,
// TODO(ianh): animate this
Material should be the one that implicitly animates level changes.

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:47: color: highlight ? const
Color(0xFFD6D6D6) : Grey[300] // TODO(ianh): animate this
0xFFD6D6D6 -> This color doesn't have a name?

I think the raised buttons are going to want their color to be configurable. 
There are certainly blue and grey ones.

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:50: onGestureTap: (_) { if
(onTap != null) onTap(); }
Is there a reason we create this event listeners instead of our client?

[Hixie, 2015-06-12 17:36:38]

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
File sky/sdk/lib/framework/widgets/raised_button.dart (right):

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:43: )
On 2015/06/12 at 03:08:04, abarth wrote:
> We could have a RenderObject that did:
> 
> new Foo(child: child, horizontal: 0.5, vertical: 0.5)

On it.

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:46: level: highlight ? 2 : 1,
// TODO(ianh): animate this
On 2015/06/12 at 03:08:04, abarth wrote:
> Material should be the one that implicitly animates level changes.

Will move the comment.

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:47: color: highlight ? const
Color(0xFFD6D6D6) : Grey[300] // TODO(ianh): animate this
On 2015/06/12 at 03:08:04, abarth wrote:
> 0xFFD6D6D6 -> This color doesn't have a name?
> 
> I think the raised buttons are going to want their color to be configurable. 
There are certainly blue and grey ones.

Agreed. Weirdly D6D6D6 doesn't have a name currently. I can add it, I guess.

https://codereview.chromium.org/1179713004/diff/60001/sky/sdk/lib/framework/w...
sky/sdk/lib/framework/widgets/raised_button.dart:50: onGestureTap: (_) { if
(onTap != null) onTap(); }
On 2015/06/12 at 03:08:04, abarth wrote:
> Is there a reason we create this event listeners instead of our client?

It seems really weird to me that a widget whose entire purpose is to detect a
tap would not have a way to tell when it has detected a tap.

Also, this encourages people to be consistent and always use the same gesture to
trigger a button, rather than having some people use pointerdown, some
pointerup, some tap, some longtap, or whatever.

[abarth-chromium, 2015-06-12 18:45:56]

lgtm

[Hixie, 2015-06-12 18:46:12]

Committed patchset #5 (id:80001) manually as
f505c9c0f781a59a73d9c54ccb0014c2f6472e71 (presubmit successful).