Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1179703005: Update V8 DEPS. (Closed)

Created:
5 years, 6 months ago by v8-autoroll
Modified:
5 years, 6 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Update V8 DEPS. Rolling v8/build/gyp to fdcd8bc10c935eff13b391644b01460593c46861 Rolling v8/tools/clang to 4cc9c6714533a07ba02ca01ed04557f055820532 TBR=machenbach@chromium.org Committed: https://crrev.com/6e7e5e833c8bddf7d6a97cd3c01f0afe5a882bd6 Cr-Commit-Position: refs/heads/master@{#29059}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M DEPS View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
v8-autoroll
5 years, 6 months ago (2015-06-17 03:00:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179703005/1
5 years, 6 months ago (2015-06-17 03:01:01 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-17 03:24:48 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e7e5e833c8bddf7d6a97cd3c01f0afe5a882bd6 Cr-Commit-Position: refs/heads/master@{#29059}
5 years, 6 months ago (2015-06-17 03:25:01 UTC) #5
Michael Achenbach
5 years, 6 months ago (2015-06-17 05:38:10 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1180193003/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] gyp change breaks calling gyp on XP:
http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%201/builds/2849.

Powered by Google App Engine
This is Rietveld 408576698