Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1179653004: Remove non-impl-side painting as an option for blink. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
jschuh, jam, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, creis+watch_chromium.org, dzhioev+watch_chromium.org, jam, darin-cc_chromium.org, oshima+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, cc-bugs_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, chrishtr, enne (OOO), pdr., vmpstr, wkorman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove non-impl-side painting as an option for blink. We no longer use it in any layout tests (recently removed the deferred per-tile-painting tests). No reason to keep this around. BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/16275d4cfd5bc6c96414d2cba629acbd6efaa3fc Cr-Commit-Position: refs/heads/master@{#334003}

Patch Set 1 : removenoimplblink: . #

Patch Set 2 : removenoimplblink: . #

Patch Set 3 : removenoimplblink: . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -182 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/blink/web_content_layer_impl.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M cc/blink/web_image_layer_impl.cc View 2 chunks +7 lines, -17 lines 0 comments Download
M cc/blink/web_layer_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/blink/web_layer_impl.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 7 chunks +1 line, -28 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 3 chunks +3 lines, -13 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download
M content/browser/resources/gpu/info_view.js View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 2 chunks +0 lines, -2 lines 0 comments Download
M content/public/common/content_switches.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M content/public/common/web_preferences.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/web_preferences.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 4 chunks +29 lines, -48 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/fake_compositor_dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/fake_compositor_dependencies.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 30 (16 generated)
danakj
5 years, 6 months ago (2015-06-10 22:33:43 UTC) #4
jam
lgtm
5 years, 6 months ago (2015-06-10 23:07:33 UTC) #6
danakj
sky could you review chrome/ ? this is non-impl-side for the renderer process only here.
5 years, 6 months ago (2015-06-10 23:09:14 UTC) #10
danakj
Oh I see jam's got the src/ ownership.
5 years, 6 months ago (2015-06-10 23:19:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179653004/60001
5 years, 6 months ago (2015-06-10 23:21:20 UTC) #14
jschuh
ipc security lgtm. (notes: boolean field removal)
5 years, 6 months ago (2015-06-10 23:30:01 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/70001)
5 years, 6 months ago (2015-06-10 23:30:17 UTC) #17
danakj
Oops, missed the is_impl_side_painting_enabled_ var in RenderThreadImpl which was being left undefined, removed, tests should ...
5 years, 6 months ago (2015-06-10 23:52:42 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179653004/80001
5 years, 6 months ago (2015-06-10 23:53:08 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/66064)
5 years, 6 months ago (2015-06-11 01:05:46 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179653004/80001
5 years, 6 months ago (2015-06-11 17:15:54 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179653004/80001
5 years, 6 months ago (2015-06-11 19:03:55 UTC) #28
commit-bot: I haz the power
Committed patchset #3 (id:80001)
5 years, 6 months ago (2015-06-11 19:23:59 UTC) #29
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 19:26:36 UTC) #30
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/16275d4cfd5bc6c96414d2cba629acbd6efaa3fc
Cr-Commit-Position: refs/heads/master@{#334003}

Powered by Google App Engine
This is Rietveld 408576698