Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1179643004: Stop the search search button from crashing stocks2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
eseidel
CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Stop the search search button from crashing stocks2 There are still a number of problems with the search feature, but at least it doesn't crash after this CL. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3dfd99d23327c06ffb8a73ce29dd5171c7085f3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -10 lines) Patch
M sky/sdk/lib/framework/editing2/editable_text.dart View 1 chunk +3 lines, -9 lines 0 comments Download
M sky/sdk/lib/framework/editing2/input.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-06-11 18:04:14 UTC) #1
eseidel
lgtm
5 years, 6 months ago (2015-06-11 18:04:59 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-06-11 18:08:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dfd99d23327c06ffb8a73ce29dd5171c7085f3a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698