Issue 1179633003: Add a roll_versions.py script and roll versions once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179633003: Add a roll_versions.py script and roll versions once. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
johnmccutchen, abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add a roll_versions.py script and roll versions once. This isn't perfect, since it makes non-minimal modifications to the yaml and xml files. In the yaml case it sorts the keys and in the xml case it doesn't do the fancy attribute wrapping, but this seems good enough to use. R=abarth@chromium.org, johnmccutchen@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1b7bcee09d2ee4fa784741499cdcc95ca4a14ff9

Patch Set 1 #

Patch Set 2 : Output now better matches expectations #

Patch Set 3 : Include a version roll #

Total comments: 1

Patch Set 4 : fix perms #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -29 lines)			Patch
M	mojo/dart/mojo_services/pubspec.yaml	View	1 2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	mojo/dart/mojom/pubspec.yaml	View	1 2	1 chunk	+5 lines, -5 lines	0 comments	Download
M	mojo/public/dart/pubspec.yaml	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	sky/apk/demo/AndroidManifest.xml	View	1 2	1 chunk	+8 lines, -15 lines	0 comments	Download
M	sky/sdk/pubspec.yaml	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
A	sky/tools/roll_versions.py	View	1 2 3	1 chunk	+93 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

abarth-chromium

lgtm https://codereview.chromium.org/1179633003/diff/40001/sky/tools/roll_versions.py File sky/tools/roll_versions.py (right): https://codereview.chromium.org/1179633003/diff/40001/sky/tools/roll_versions.py#newcode1 sky/tools/roll_versions.py:1: Copyright block?

5 years, 6 months ago (2015-06-10 23:10:56 UTC) #3

eseidel

5 years, 6 months ago (2015-06-10 23:16:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 (id:60001) manually as
1b7bcee09d2ee4fa784741499cdcc95ca4a14ff9 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages