Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(117)

Issue 1179613004: Adding unittest for blink gc dump provider. (Closed)

Created:
4 years, 10 months ago by ssid
Modified:
4 years, 10 months ago
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@oilpan_n1
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Adding unittest for blink gc dump provider. This CL adds the unittest for the dump provider, which was added earlier in crrev.com/1148823002 BUG=490087 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
A Source/platform/heap/BlinkGCMemoryDumpProviderTest.cpp View 1 chunk +24 lines, -0 lines 0 comments Download
M Source/platform/heap/blink_heap.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
ssid
4 years, 10 months ago (2015-06-15 16:13:12 UTC) #3
ssid
4 years, 10 months ago (2015-06-15 16:13:12 UTC) #4
Primiano Tucci (use gerrit)
LGTM, +haraken
4 years, 10 months ago (2015-06-15 16:21:22 UTC) #6
haraken
LGTM
4 years, 10 months ago (2015-06-15 16:21:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179613004/1
4 years, 10 months ago (2015-06-16 10:06:05 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-16 10:10:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197169

Powered by Google App Engine
This is Rietveld 408576698