Issue 1179593002: Revert of Specify GIT_DIR when running git-config in a mirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179593002: Revert of Specify GIT_DIR when running git-config in a mirror. (Closed)

Created:
5 years, 6 months ago by hinoka

Modified:
5 years, 6 months ago

Reviewers:
agable, szager1

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

Revert of Specify GIT_DIR when running git-config in a mirror. (patchset #4 id:60001 of https://codereview.chromium.org/1167193002/) Reason for revert: Potentially broke the NaCl toolchain builders: crbug.com/498942 Speculative revert. Original issue's description: > Specify GIT_DIR when running git-config in a mirror. > > BUG=497894 > R=hinoka@chromium.org,agable@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295587 TBR=agable@chromium.org,szager@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497894 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295607

Created: 5 years, 6 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -10 lines)			Patch
	M	git_cache.py	View		2 chunks	+7 lines, -10 lines	0 comments	Download

Total messages: 3 (0 generated)

hinoka

Created Revert of Specify GIT_DIR when running git-config in a mirror.

5 years, 6 months ago (2015-06-10 19:18:44 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179593002/1

5 years, 6 months ago (2015-06-10 19:18:57 UTC) #2

commit-bot: I haz the power

5 years, 6 months ago (2015-06-10 19:19:09 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295607