Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1179573004: Correct iOS device build for latest Xcode beta. (Closed)

Created:
5 years, 6 months ago by justincohen
Modified:
5 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct iOS device build for latest Xcode beta. Stop referring to dylib directly, and instead use the linker shortcut. With the latest Xcode beta, some dylibs are now named .tbd, so referencing the actual path for simulator (dylib) and device (tbd) would make for a very complicated build file. Using the linker short name bypases all of that. BUG=499098 TBRs for small iOS only gyp changes. TBR=scottmg@chromium.org (libxml) TBR=michaeln@chromium.org (sqlite) Committed: https://crrev.com/23bb216c5f30782e97f6a51bcafb53f6607ab051 Cr-Commit-Position: refs/heads/master@{#333978}

Patch Set 1 #

Patch Set 2 : Use OTHER_LDFLAGS #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M ios/crnet/crnet_consumer/crnet_consumer.gyp View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M ios/third_party/gcdwebserver/gcdwebserver.gyp View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M net/net_common.gypi View 1 2 1 chunk +5 lines, -1 line 0 comments Download
M third_party/class-dump/class-dump.gyp View 1 2 1 chunk +9 lines, -18 lines 0 comments Download
M third_party/libxml/libxml.gyp View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 2 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
justincohen
This seems to be a cleaner attempt to work around the new library files in ...
5 years, 6 months ago (2015-06-10 20:53:24 UTC) #2
justincohen
stuartmorgan@ We use similar syntax in base.gyp. WDYT?
5 years, 6 months ago (2015-06-10 21:14:20 UTC) #4
rohitrao (ping after 24h)
Is there a bug for this? Can you update the description (and the bug) to ...
5 years, 6 months ago (2015-06-10 21:18:35 UTC) #6
stuartmorgan
Huh, so we do. I'm fine with the approach, but as Rohit said we really ...
5 years, 6 months ago (2015-06-10 21:26:43 UTC) #7
justincohen
Updated the comment and added a bug, and changed to use the Xcode correct format ...
5 years, 6 months ago (2015-06-11 00:40:44 UTC) #8
droger
LGTM Approach looks good, but please wait for sdefresne approval too, he's more familiar than ...
5 years, 6 months ago (2015-06-11 11:35:35 UTC) #10
sdefresne
lgtm with a nit (so that it is easier to add other values in the ...
5 years, 6 months ago (2015-06-11 14:13:11 UTC) #11
justincohen
https://codereview.chromium.org/1179573004/diff/20001/ios/crnet/crnet_consumer/crnet_consumer.gyp File ios/crnet/crnet_consumer/crnet_consumer.gyp (right): https://codereview.chromium.org/1179573004/diff/20001/ios/crnet/crnet_consumer/crnet_consumer.gyp#newcode55 ios/crnet/crnet_consumer/crnet_consumer.gyp:55: ] On 2015/06/11 14:13:11, sdefresne wrote: > nit: "]," ...
5 years, 6 months ago (2015-06-11 14:25:12 UTC) #12
justincohen
rsleevi@ for /net OWNERS, small iOS only gyp change. PTAL!
5 years, 6 months ago (2015-06-11 15:04:56 UTC) #14
Ryan Sleevi
lgtm
5 years, 6 months ago (2015-06-11 16:13:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179573004/40001
5 years, 6 months ago (2015-06-11 16:15:06 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-11 17:39:17 UTC) #19
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 17:40:11 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/23bb216c5f30782e97f6a51bcafb53f6607ab051
Cr-Commit-Position: refs/heads/master@{#333978}

Powered by Google App Engine
This is Rietveld 408576698