Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2240)

Unified Diff: remoting/signaling/xmpp_login_handler.cc

Issue 1179543004: Fix XmppLoginHandler to handle destruction from delegate methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/signaling/xmpp_login_handler.h ('k') | remoting/signaling/xmpp_login_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/signaling/xmpp_login_handler.cc
diff --git a/remoting/signaling/xmpp_login_handler.cc b/remoting/signaling/xmpp_login_handler.cc
index cc3ae94a4e0ab63405f6c571236e2114b5c2253a..448ecbef6fae382fbed139f589fe54bfee6469aa 100644
--- a/remoting/signaling/xmpp_login_handler.cc
+++ b/remoting/signaling/xmpp_login_handler.cc
@@ -221,14 +221,14 @@ void XmppLoginHandler::OnParserError() {
}
void XmppLoginHandler::StartStream(const std::string& first_message) {
- delegate_->SendMessage("<stream:stream to=\"" + server_ +
- "\" version=\"1.0\" xmlns=\"jabber:client\" "
- "xmlns:stream=\"http://etherx.jabber.org/streams\">" +
- first_message);
stream_parser_.reset(new XmppStreamParser());
stream_parser_->SetCallbacks(
base::Bind(&XmppLoginHandler::OnStanza, base::Unretained(this)),
base::Bind(&XmppLoginHandler::OnParserError, base::Unretained(this)));
+ delegate_->SendMessage("<stream:stream to=\"" + server_ +
+ "\" version=\"1.0\" xmlns=\"jabber:client\" "
+ "xmlns:stream=\"http://etherx.jabber.org/streams\">" +
+ first_message);
}
void XmppLoginHandler::OnError(SignalStrategy::Error error) {
« no previous file with comments | « remoting/signaling/xmpp_login_handler.h ('k') | remoting/signaling/xmpp_login_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698