Issue 1179543003: DevTools: Do not allow JS frames on top of non-JS invocation events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179543003: DevTools: Do not allow JS frames on top of non-JS invocation events. (Closed)

Created:
5 years, 6 months ago by alph

Modified:
5 years, 6 months ago

Reviewers:
yurys

CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

DevTools: Do not allow JS frames on top of non-JS invocation events. BUG=498717 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196956

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -44 lines)			Patch
M	LayoutTests/inspector/tracing/timeline-js-callstacks-expected.txt	View	2 chunks	+25 lines, -32 lines	0 comments	Download
M	LayoutTests/inspector/tracing/timeline-js-samping-tracing-expected.txt	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineJSProfile.js	View	3 chunks	+3 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179543003/1

5 years, 6 months ago (2015-06-11 12:47:48 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-11 15:19:54 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196956

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages