Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 1179543002: [turbofan] Make IfException projections consume effects. (Closed)

Created:
5 years, 6 months ago by Michael Starzinger
Modified:
5 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make IfException projections consume effects. This is needed in order to allow expansion of a throwing node into a set of nodes that produce different effects for the successful and the exceptional continuation. R=bmeurer@chromium.org Committed: https://crrev.com/3548c5c6f1122854bdf8a4f5c6306f1652446a06 Cr-Commit-Position: refs/heads/master@{#28918}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -41 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/graph-reducer.cc View 2 chunks +3 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/node-properties.cc View 1 chunk +3 lines, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/graph-reducer-unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/compiler/node-properties-unittest.cc View 6 chunks +36 lines, -27 lines 0 comments Download
M test/unittests/compiler/scheduler-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/tail-call-optimization-unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 6 months ago (2015-06-10 14:48:07 UTC) #1
Benedikt Meurer
lgtm
5 years, 6 months ago (2015-06-11 04:20:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179543002/1
5 years, 6 months ago (2015-06-11 04:20:46 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 04:22:00 UTC) #5
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 04:22:25 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3548c5c6f1122854bdf8a4f5c6306f1652446a06
Cr-Commit-Position: refs/heads/master@{#28918}

Powered by Google App Engine
This is Rietveld 408576698