Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 1179523002: NaCl: Clean up error handling during NaCl loader startup in OnStart() (Closed)

Created:
5 years, 6 months ago by Mark Seaborn
Modified:
5 years, 6 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NaCl: Clean up error handling during NaCl loader startup in OnStart() If handling of NaClProcessMsg_Start fails, we want the NaCl loader process to exit, otherwise it will potentially hang around uselessly without being killed. So change the error handling to exit with fatal errors instead of returning to the message loop. nonsfi/nonsfi_listener.cc already uses fatal errors, so no change is required there. BUG=496287 TEST=none Committed: https://crrev.com/2127015393cf11f159905b0232f01e5b5310ed41 Cr-Commit-Position: refs/heads/master@{#333760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M components/nacl/loader/nacl_listener.cc View 4 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
5 years, 6 months ago (2015-06-10 16:59:25 UTC) #2
jvoung (off chromium)
lgtm
5 years, 6 months ago (2015-06-10 17:25:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179523002/1
5 years, 6 months ago (2015-06-10 17:30:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-10 18:14:04 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 18:14:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2127015393cf11f159905b0232f01e5b5310ed41
Cr-Commit-Position: refs/heads/master@{#333760}

Powered by Google App Engine
This is Rietveld 408576698