Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 11795004: Continue threading context through unit tests. (Closed)

Created:
7 years, 11 months ago by Elliot Glaysher
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sadrul, hashimoto+watch_chromium.org, ben+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, davidbarr+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org
Visibility:
Public.

Description

Continue threading context through unit tests. - views_unittest now passes with the assert that checks that we have context. - ash_unittest...is making progress towards that and this patch is already big. BUG=161882 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175389

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -187 lines) Patch
M ash/display/shared_display_edge_indicator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 4 chunks +35 lines, -23 lines 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +31 lines, -30 lines 0 comments Download
M ash/screen_ash_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M ash/shell/toplevel_window.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/shell_unittest.cc View 3 chunks +27 lines, -23 lines 0 comments Download
M ash/test/ash_test_base.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/test/ash_test_base.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M ash/wm/custom_frame_view_ash_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/frame_painter_unittest.cc View 1 chunk +34 lines, -30 lines 0 comments Download
M ash/wm/gestures/long_press_affordance_handler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/shelf_layout_manager_unittest.cc View 8 chunks +8 lines, -0 lines 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M ash/wm/system_modal_container_layout_manager_unittest.cc View 20 chunks +58 lines, -39 lines 0 comments Download
M ash/wm/window_modality_controller_unittest.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/accessibility/accessibility_event_router_views_unittest.cc View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_bubble_unittest.cc View 1 chunk +10 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/test/child_modal_window.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/test/child_modal_window.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Elliot Glaysher
7 years, 11 months ago (2013-01-07 19:06:56 UTC) #1
Elliot Glaysher
(NotificationPromoTest can be ignored since it is failing everywhere, including ToT and platforms that aren't ...
7 years, 11 months ago (2013-01-07 20:27:44 UTC) #2
Ben Goodger (Google)
7 years, 11 months ago (2013-01-07 21:19:42 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698