Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1179453002: ServiceWorker: Reset idle timer when we dispatch message event (Closed)

Created:
5 years, 6 months ago by kinuko
Modified:
5 years, 6 months ago
Reviewers:
falken, nhiroki
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Reset idle timer when we dispatch message event BUG=498121 TEST=ServiceWorkerVersionTest.IdleTimeout Committed: https://crrev.com/e3e3ec328e1953fae69a034d529f6ec245fcfc08 Cr-Commit-Position: refs/heads/master@{#333742}

Patch Set 1 #

Total comments: 2

Patch Set 2 : NULL -> nullptr #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -2 lines) Patch
M content/browser/service_worker/embedded_worker_test_helper.h View 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 5 chunks +33 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 1 3 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
kinuko
One line change, rest is mostly for testing. PTL
5 years, 6 months ago (2015-06-10 05:52:26 UTC) #2
nhiroki
lgtm https://codereview.chromium.org/1179453002/diff/1/content/browser/service_worker/service_worker_version_unittest.cc File content/browser/service_worker/service_worker_version_unittest.cc (right): https://codereview.chromium.org/1179453002/diff/1/content/browser/service_worker/service_worker_version_unittest.cc#newcode123 content/browser/service_worker/service_worker_version_unittest.cc:123: MessagePortService::GetInstance()->Create(MSG_ROUTING_NONE, NULL, &port_id); nit: nullptr
5 years, 6 months ago (2015-06-10 08:00:24 UTC) #3
falken
lgtm
5 years, 6 months ago (2015-06-10 12:47:58 UTC) #4
kinuko
Thanks! https://codereview.chromium.org/1179453002/diff/1/content/browser/service_worker/service_worker_version_unittest.cc File content/browser/service_worker/service_worker_version_unittest.cc (right): https://codereview.chromium.org/1179453002/diff/1/content/browser/service_worker/service_worker_version_unittest.cc#newcode123 content/browser/service_worker/service_worker_version_unittest.cc:123: MessagePortService::GetInstance()->Create(MSG_ROUTING_NONE, NULL, &port_id); On 2015/06/10 08:00:24, nhiroki wrote: ...
5 years, 6 months ago (2015-06-10 14:33:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179453002/20001
5 years, 6 months ago (2015-06-10 14:33:48 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-10 16:36:44 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 16:37:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e3e3ec328e1953fae69a034d529f6ec245fcfc08
Cr-Commit-Position: refs/heads/master@{#333742}

Powered by Google App Engine
This is Rietveld 408576698