Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: chrome/browser/resources/gaia_auth/background.js

Issue 1179433002: signin: Abort previous 'channelConnected' handling on retry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/gaia_auth/channel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/gaia_auth/background.js
diff --git a/chrome/browser/resources/gaia_auth/background.js b/chrome/browser/resources/gaia_auth/background.js
index 3b529f33463c21d3d85f8d7cd96b3431e777982d..482a4d1df4c8d115a686c8e70e26a620c9852608 100644
--- a/chrome/browser/resources/gaia_auth/background.js
+++ b/chrome/browser/resources/gaia_auth/background.js
@@ -28,13 +28,14 @@
* the associated tab id.
*/
function BackgroundBridgeManager() {
+ this.bridges_ = {};
}
BackgroundBridgeManager.prototype = {
CONTINUE_URL_BASE: 'chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik' +
'/success.html',
// Maps a tab id to its associated BackgroundBridge.
- bridges_: {},
+ bridges_: null,
run: function() {
chrome.runtime.onConnect.addListener(this.onConnect_.bind(this));
@@ -103,6 +104,7 @@ BackgroundBridgeManager.prototype = {
*/
function BackgroundBridge(tabId) {
this.tabId_ = tabId;
+ this.passwordStore_ = {};
}
BackgroundBridge.prototype = {
@@ -148,7 +150,7 @@ BackgroundBridge.prototype = {
// Whether SAML flow is going.
isSAML_: false,
- passwordStore_: {},
+ passwordStore_: null,
channelMain_: null,
channelInjected_: null,
« no previous file with comments | « no previous file | chrome/browser/resources/gaia_auth/channel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698