signin: Abort previous 'channelConnected' handling on retry

chrome/browser/resources/gaia_auth/channel.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Channel to the background script.
  */
 function Channel() {
+  // Message port to use to communicate with background script.
+  this.port_ = null;
+
+  // Registered message callbacks.
+  this.messageCallbacks_ = {};
+
+  // Internal request id to track pending requests.
+  this.nextInternalRequestId_ = 0;

[dzhioev (left Google), 2015/06/10 20:04:19]

This initialized with primitive type, so you can left it where it was before.

[xiyuan, 2015/06/10 20:21:12]

Yes, we can leave it where it was. But do you think it would be easier to read
to keep all member vars together?

+
+  // Pending internal request callbacks.
+  this.internalRequestCallbacks_ = {};
 }
 
 /** @const */
 Channel.INTERNAL_REQUEST_MESSAGE = 'internal-request-message';
 
 /** @const */
 Channel.INTERNAL_REPLY_MESSAGE = 'internal-reply-message';
 
 Channel.prototype = {
-  // Message port to use to communicate with background script.
-  port_: null,
-
-  // Registered message callbacks.
-  messageCallbacks_: {},
-
-  // Internal request id to track pending requests.
-  nextInternalRequestId_: 0,
-
-  // Pending internal request callbacks.
-  internalRequestCallbacks_: {},

[dzhioev (left Google), 2015/06/10 20:04:19]

Same here

-
   /**
    * Initialize the channel with given port for the background script.
    */
   init: function(port) {
     this.port_ = port;
     this.port_.onMessage.addListener(this.onMessage_.bind(this));
   },
 
   /**
    * Connects to the background script with the given name.
@@ skipping 70 matching lines @@
   }
 };
 
 /**
  * Class factory.
  * @return {Channel}
  */
 Channel.create = function() {
   return new Channel();
 };