mandoline filesystem: Save cookie data to the mojo:filesystem.

mojo/runner/scoped_user_data_dir.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "mojo/runner/scoped_user_data_dir.h"
+
+#include "base/command_line.h"
+#include "base/logging.h"
+#include "mojo/runner/switches.h"
+
+namespace mojo {
+namespace runner {
+
+ScopedUserDataDir::ScopedUserDataDir() {
+  base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+  if (command_line->HasSwitch(switches::kUseTemporaryUserDataDir)) {

[jam, 2015/06/25 15:28:23]

nit: early return here would remove indentation

+    if (command_line->HasSwitch(switches::kUserDataDir)) {

[jam, 2015/06/25 15:28:23]

nit: just CHECK(!command_line->HasSwitch(switches::kUserDataDir));

[Elliot Glaysher, 2015/06/25 22:46:48]

Disagree. Errors that users can trigger should have proper error messages. Did
clean up message a bit more though.

+      // User should not specify a --user-data-dir manually when using
+      // --use-temporary-user-data-dir. The point of the flag is to let the
+      // mojo runner process manage the lifetime of the user data dir.
+      LOG(ERROR) << "Can not have both --user-data-dir and "
+                 << "--use-temporary-user-data-dir in the same process.";
+      return;
+    }
+
+    if (!temp_dir_.CreateUniqueTempDir()) {
+      LOG(ERROR) << "Failed to create a temporary user data dir.";
+      return;
+    }
+
+    command_line->AppendSwitchPath(switches::kUserDataDir, temp_dir_.path());
+  }
+}
+
+ScopedUserDataDir::~ScopedUserDataDir() {
+}
+
+}  // namespace runner
+}  // namespace mojo