mandoline filesystem: Save cookie data to the mojo:filesystem.

mojo/tools/mopy/gtest.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import multiprocessing
 import os
 import re
+import shutil
 import subprocess
 import sys
+import tempfile
 import time
 
 from mopy.config import Config
 from mopy.paths import Paths
 
 
 def set_color():
   """Run gtests with color on TTY, unless its environment variable is set."""
   if sys.stdout.isatty() and "GTEST_COLOR" not in os.environ:
     logging.getLogger().debug("Setting GTEST_COLOR=yes")
@@ skipping 126 matching lines @@
   if process.is_alive():
     process.terminate()
     process.join()
     return "Error: Test timeout after %s seconds" % timeout_in_seconds
   return result.get()
 
 
 def _run_test(config, shell, args, apptest, result):
   """Run the given test and puts the output in |result|."""
   if (config.target_os != Config.OS_ANDROID):
+    temp_dir = tempfile.mkdtemp()

[msw, 2015/06/24 00:14:40]

Avoid making the temp dir and appending the argument when listing tests; you can
add a check like in _build_command_line: |if not "--gtest_list_tests" in args:|.
I'd like a cleaner fix for per-test temp-dirs (given this problem and the error
output comment below), but nothing brilliant comes to mind.

[Elliot Glaysher, 2015/06/24 22:22:41]

I've changed the entire approach here. I set a --use-temporary-user-data-dir
flag, which the mojo_runner sees, creates a temporary data directory very early
in the lifecycle and then sets the --user-data-dir flag to that in the C++ code.
That should works cross platform with android.

     command = _build_command_line(config, args, apptest)
+    command += ['--user-data-dir=%s' % temp_dir]

[msw, 2015/06/24 00:14:40]

Hmm, this argument won't appear in the logs when _print_error is called with
other _build_command_line invocations... Maybe add some other logging so it's at
least printed somewhere? You might not be able to use
|logging.getLogger().debug("Using temporary user-data-dir: " + temp_dir)| since
this function is run in a separate process, but you should be able to append a
string like that to |result|.

     result.put(subprocess.check_output(command, stderr=subprocess.STDOUT))
+    shutil.rmtree(temp_dir)
     return
 
   assert shell
   (r, w) = os.pipe()
   with os.fdopen(r, "r") as rf:
     with os.fdopen(w, "w") as wf:
       shell.StartActivity('MojoShellActivity', args + [apptest], wf, wf.close)

[msw, 2015/06/24 00:14:40]

I guess we'll want a shell.mkdtemp and shell.rmtree implemented in
mojo/tools/mopy/android.py using pylib's adb commands (as much as possible)

       result.put(rf.read())