Issue 1179413008: If Color constructor is passed a value > 0xFFFFFFFF, Sky crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1179413008: If Color constructor is passed a value > 0xFFFFFFFF, Sky crashes (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

If Color constructor is passed a value > 0xFFFFFFFF, Sky crashes We now ensure the color is <= 0xFFFFFFFF. Fixes #245 R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/033cdb2403d2d106f1fac6d1273d9018538bf9f5

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -5 lines)			Patch
M	sky/engine/core/painting/Color.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
A	sky/tests/raw/color_bounds.dart	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
A	sky/tests/raw/color_bounds-expected.txt	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

abarth-chromium

5 years, 6 months ago (2015-06-18 17:32:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
033cdb2403d2d106f1fac6d1273d9018538bf9f5 (presubmit successful).