Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 1179413005: Implement debugName() in WebDataConsumerHandle subclasses in content/child/ (Closed)

Created:
5 years, 6 months ago by hiroshige
Modified:
5 years, 6 months ago
Reviewers:
kinuko, yhirano
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement debugName() in WebDataConsumerHandle subclasses in content/child/ BUG=480746 Committed: https://crrev.com/ca2b242988421b7c5faef294ed387db8f7745205 Cr-Commit-Position: refs/heads/master@{#335216}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/child/shared_memory_data_consumer_handle.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/shared_memory_data_consumer_handle.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/child/web_data_consumer_handle_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/web_data_consumer_handle_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hiroshige
PTAL.
5 years, 6 months ago (2015-06-18 11:52:42 UTC) #2
yhirano
lgtm
5 years, 6 months ago (2015-06-18 11:55:14 UTC) #3
hiroshige
+kinuko@ Could you take a look as content/ OWNER?
5 years, 6 months ago (2015-06-18 12:03:49 UTC) #5
kinuko
lgtm
5 years, 6 months ago (2015-06-18 20:00:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179413005/1
5 years, 6 months ago (2015-06-19 05:08:31 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 06:04:32 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 06:05:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca2b242988421b7c5faef294ed387db8f7745205
Cr-Commit-Position: refs/heads/master@{#335216}

Powered by Google App Engine
This is Rietveld 408576698