Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: runtime/bin/directory_macos.cc

Issue 11794048: Fix race condition in Directory.create. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory_linux.cc ('k') | runtime/bin/directory_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/directory_macos.cc
diff --git a/runtime/bin/directory_macos.cc b/runtime/bin/directory_macos.cc
index 59977a3886dd54334f2e220fb5cc12a5d487afb8..241fce2f9cd31ae2123d67e5c95b3897afe2bb3a 100644
--- a/runtime/bin/directory_macos.cc
+++ b/runtime/bin/directory_macos.cc
@@ -381,12 +381,14 @@ char* Directory::Current() {
bool Directory::Create(const char* dir_name) {
- // If the directory already exists and is a directory do not
- // attempt to create it again and treat it as a success.
- if (Exists(dir_name) == EXISTS) return true;
// Create the directory with the permissions specified by the
// process umask.
- return (TEMP_FAILURE_RETRY(mkdir(dir_name, 0777)) == 0);
+ int result = TEMP_FAILURE_RETRY(mkdir(dir_name, 0777));
+ // If the directory already exists, treat it as a success.
+ if (result == -1 && errno == EEXIST) {
+ return (Exists(dir_name) == EXISTS);
+ }
+ return (result == 0);
}
« no previous file with comments | « runtime/bin/directory_linux.cc ('k') | runtime/bin/directory_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698