Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1021)

Unified Diff: sdk/lib/async/stream_impl.dart

Issue 11794043: Remove Signal class and use Future/.whenComplete instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Comment updated. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/async/stream_controller.dart ('k') | tests/lib/async/event_helper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/async/stream_impl.dart
diff --git a/sdk/lib/async/stream_impl.dart b/sdk/lib/async/stream_impl.dart
index 617a616b25037a38a629cf357a5b3800f4e8ea0d..fbc146a2edd5c84679ff3f663502fdbff4bdb0f4 100644
--- a/sdk/lib/async/stream_impl.dart
+++ b/sdk/lib/async/stream_impl.dart
@@ -216,7 +216,7 @@ abstract class _StreamImpl<T> extends Stream<T> {
* subscriptions, e.g., a filtering stream pausing its own source if all its
* subscribers are paused.
*/
- void _pause(_StreamListener<T> listener, Signal resumeSignal) {
+ void _pause(_StreamListener<T> listener, Future resumeSignal) {
assert(identical(listener._source, this));
if (!listener._isSubscribed) {
throw new StateError("Subscription has been canceled.");
@@ -225,7 +225,7 @@ abstract class _StreamImpl<T> extends Stream<T> {
bool wasPaused = _isPaused;
_incrementPauseCount(listener);
if (resumeSignal != null) {
- resumeSignal.then(() { this._resume(listener, true); });
+ resumeSignal.whenComplete(() { this._resume(listener, true); });
}
if (!wasPaused) {
_onPauseStateChange();
@@ -684,7 +684,7 @@ class _StreamSubscriptionImpl<T> extends _StreamListener<T>
_source._cancel(this);
}
- void pause([Signal resumeSignal]) {
+ void pause([Future resumeSignal]) {
_source._pause(this, resumeSignal);
}
@@ -983,7 +983,7 @@ class _DoneSubscription<T> implements StreamSubscription<T> {
_handler = handleDone;
}
- void pause([Signal signal]) {
+ void pause([Future signal]) {
if (_isComplete) {
throw new StateError("Subscription has been canceled.");
}
« no previous file with comments | « sdk/lib/async/stream_controller.dart ('k') | tests/lib/async/event_helper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698