sdk/lib/async/future_impl.dart - Issue 11794043: Remove Signal class and use Future/.whenComplete instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/future_impl.dart

Issue 11794043: Remove Signal class and use Future/.whenComplete instead. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comment updated. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/future_impl.dart

diff --git a/sdk/lib/async/future_impl.dart b/sdk/lib/async/future_impl.dart

index bf071e0e7bc60b50e2d59859d06090f20855463f..e6d7675775a89a73bc8f71d867aa95a40ac5fd8f 100644

--- a/sdk/lib/async/future_impl.dart

+++ b/sdk/lib/async/future_impl.dart

@@ -14,7 +14,7 @@ class _CompleterImpl<T> implements Completer<T> {

_CompleterImpl() : future = new _FutureImpl<T>();

- void complete(T value) {

+ void complete([T value]) {

if (_isComplete) throw new StateError("Future already completed");

_isComplete = true;

_FutureImpl future = this.future;

« no previous file with comments | « sdk/lib/async/future.dart ('k') | sdk/lib/async/signal.dart » ('j') | no next file with comments »