Issue 11794042: Switch to using FilePathWatcher::Callback instead of FilePathWatcher::Delegate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11794042: Switch to using FilePathWatcher::Callback instead of FilePathWatcher::Delegate. (Closed)

Created:
7 years, 11 months ago by darin (slow to review)

Modified:
7 years, 11 months ago

Reviewers:
jam, Mattias Nissler (ping if slow)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Switch to using FilePathWatcher::Callback instead of FilePathWatcher::Delegate. BUG=130980 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175570

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -35 lines)			Patch
	M	content/browser/plugin_service_impl.h	View		2 chunks	+4 lines, -8 lines	0 comments	Download
	M	content/browser/plugin_service_impl.cc	View		5 chunks	+22 lines, -27 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/darin@chromium.org/11794042/1

7 years, 11 months ago (2013-01-08 19:00:49 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 11 months ago (2013-01-08 19:03:03 UTC) #5

Message was sent while issue was closed.

Back from vacation... LGTM FWIW.