Issue 11794040: Complete HSTS preload for *.code.google.com.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11794040: Complete HSTS preload for *.code.google.com. (Closed)

Created:
7 years, 11 months ago by palmer

Modified:
7 years, 11 months ago

Reviewers:
agl, Ryan Sleevi

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Complete HSTS preload for *.code.google.com. BUG=158594 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175569

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	net/base/transport_security_state_static.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/base/transport_security_state_static.json	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

agl

LGTM if code.google.com fixed upload.code.google.com, or whatever it was.

7 years, 11 months ago (2013-01-08 05:44:44 UTC) #2

palmer

> LGTM if http://code.google.com fixed http://upload.code.google.com, or whatever it was. Yes, it was uploads.code.google.com, and ...

7 years, 11 months ago (2013-01-08 18:13:04 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/11794040/1

7 years, 11 months ago (2013-01-08 19:00:20 UTC) #4

commit-bot: I haz the power

7 years, 11 months ago (2013-01-08 19:00:23 UTC) #5

Presubmit check for 11794040-1 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit Messages **
Most layers below src/chrome/ should not hardcode service URLs.
Are you sure this is correct? (Contact: joi@chromium.org)
    net/base/transport_security_state_static.json:187:      { "name":
"code.google.com", "include_subdomains": true, "mode": "force-https", "pins":
"google" },

** Presubmit Warnings **
Found lines longer than 80 characters (first 5 shown).
  net/base/transport_security_state_static.h, line 344, 81 chars

Presubmit checks took 1.0s to calculate.

Expand Messages | Collapse Messages