Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Unified Diff: build/android/run_tests.py

Issue 11794039: [Android] Remove fast_and_loose option from the gtest runner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/utils/test_options_parser.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/run_tests.py
diff --git a/build/android/run_tests.py b/build/android/run_tests.py
index 7100acf09698eeeb1f3e34a5d326d6b5d9034129..a4727f0fe7b71a649bcc197272eaa714ca2baf9d 100755
--- a/build/android/run_tests.py
+++ b/build/android/run_tests.py
@@ -112,7 +112,7 @@ class TestSharder(BaseTestSharder):
def __init__(self, attached_devices, test_suite, gtest_filter,
test_arguments, timeout, cleanup_test_files, tool,
- log_dump_name, fast_and_loose, build_type, in_webkit_checkout,
+ log_dump_name, build_type, in_webkit_checkout,
flakiness_server=None):
BaseTestSharder.__init__(self, attached_devices, build_type)
self.test_suite = test_suite
@@ -122,7 +122,6 @@ class TestSharder(BaseTestSharder):
self.cleanup_test_files = cleanup_test_files
self.tool = tool
self.log_dump_name = log_dump_name
- self.fast_and_loose = fast_and_loose
self.in_webkit_checkout = in_webkit_checkout
self.flakiness_server = flakiness_server
self.all_tests = []
@@ -169,7 +168,6 @@ class TestSharder(BaseTestSharder):
self.tool,
0,
not not self.log_dump_name,
- self.fast_and_loose,
self.build_type,
self.in_webkit_checkout)
# The executable/apk needs to be copied before we can call GetAllTests.
@@ -205,7 +203,6 @@ class TestSharder(BaseTestSharder):
self.timeout,
self.cleanup_test_files, self.tool, index,
not not self.log_dump_name,
- self.fast_and_loose,
self.build_type,
self.in_webkit_checkout)
@@ -253,7 +250,7 @@ def _RunATestSuite(options):
if n > 0:
# Creates a temporary AVD for the extra emulators.
avd_name = 'run_tests_avd_%d' % n
- buildbot_emulator = emulator.Emulator(avd_name, options.fast_and_loose)
+ buildbot_emulator = emulator.Emulator(avd_name)
buildbot_emulator.Launch(kill_all_emulators=n == 0)
t.Stop()
buildbot_emulators.append(buildbot_emulator)
@@ -289,7 +286,6 @@ def _RunATestSuite(options):
options.cleanup_test_files,
options.tool,
options.log_dump,
- options.fast_and_loose,
options.build_type,
options.webkit,
options.flakiness_dashboard_server)
« no previous file with comments | « build/android/pylib/utils/test_options_parser.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698