Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2726)

Unified Diff: build/android/pylib/gtest/single_test_runner.py

Issue 11794039: [Android] Remove fast_and_loose option from the gtest runner. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/emulator.py ('k') | build/android/pylib/utils/test_options_parser.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/single_test_runner.py
diff --git a/build/android/pylib/gtest/single_test_runner.py b/build/android/pylib/gtest/single_test_runner.py
index 23c795e22ed4705d32d4ce8778ba1354c1d086ed..22d5c128d64ee9f317bcaf2df89dabdc599fc597 100644
--- a/build/android/pylib/gtest/single_test_runner.py
+++ b/build/android/pylib/gtest/single_test_runner.py
@@ -39,7 +39,7 @@ class SingleTestRunner(BaseTestRunner):
def __init__(self, device, test_suite, gtest_filter, test_arguments, timeout,
cleanup_test_files, tool_name, shard_index, dump_debug_info,
- fast_and_loose, build_type, in_webkit_checkout):
+ build_type, in_webkit_checkout):
BaseTestRunner.__init__(self, device, tool_name, shard_index, build_type)
self._running_on_emulator = self.device.startswith('emulator')
self._gtest_filter = gtest_filter
@@ -51,7 +51,6 @@ class SingleTestRunner(BaseTestRunner):
os.path.basename(test_suite), gtest_filter)
else:
self.dump_debug_info = None
- self.fast_and_loose = fast_and_loose
self.in_webkit_checkout = in_webkit_checkout
logging.warning('Test suite: ' + test_suite)
@@ -222,7 +221,7 @@ class SingleTestRunner(BaseTestRunner):
self.test_package.PushDataAndPakFiles()
self.tool.CopyFiles()
test_data = self.GetDataFilesForTestSuite()
- if test_data and not self.fast_and_loose:
+ if test_data:
# Make sure SD card is ready.
self.adb.WaitForSdCardReady(20)
for data in test_data:
« no previous file with comments | « build/android/emulator.py ('k') | build/android/pylib/utils/test_options_parser.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698