Adds functionality to pack an extension / app from the app.

chrome/common/extensions/api/developer_private.idl

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // developerPrivate API.
 // This is a private API exposing developing and debugging functionalities for
 // apps and extensions.
 
 namespace developerPrivate {
 
@@ skipping 50 matching lines @@
     ItemInspectView[] views;
   };
 
   dictionary InspectOptions {
     DOMString extension_id;
     DOMString render_process_id;
     DOMString render_view_id;
     boolean incognito;
   };
 
+  enum PackStatus {
+    SUCCESS,
+    ERROR,
+    WARNING
+  };
+
+  dictionary PackItemResponse {
+

[miket_OOO, 2013/01/09 18:52:41]

this newline isn't needed (follow style of others in this file)

[Gaurav, 2013/01/12 01:08:26]

Done.

+    // The response message of success or error.
+    DOMString message;
+
+    // Unpacked items's path.
+    DOMString item_path;

[miket_OOO, 2013/01/09 18:52:41]

The prevailing style in the IDL is itemPath, pemPath, etc. They get fixed for
C++ style during generation.

[Gaurav, 2013/01/12 01:08:26]

I changed the naming from camel case to underscores, as enum generation had some
issues with it.

Should I replace all the variables in the IDL to caml case ?

Thanks.

On 2013/01/09 18:52:41, miket wrote:

+
+    // Permanent key path.
+    DOMString pem_path;
+
+    long override_flags;
+    PackStatus status;
+  };
+
   callback BooleanCallback = void (boolean result);
   callback ItemsInfoCallback = void (ItemInfo[] result);
   callback GetStringsCallback = void (object result);
+  callback PathCallback = void (DOMString path);
+  callback PackCallback = void (PackItemResponse response);
 
   interface Functions {
     // Runs auto update for extensions and apps immediately.
     // |callback| : Called with the boolean result, true if autoUpdate is
     // successful.
     static void autoUpdate(BooleanCallback callback);
 
     // Returns information of all the extensions and apps installed.
     // |include_disabled| : include disabled items.
     // |include_terminated| : include terminated items.
     // |callback| : Called with items info.
     static void getItemsInfo(boolean include_disabled,
                              boolean include_terminated,
                              ItemsInfoCallback callback);
 
     // Opens an inspect window for given |options|
     static void inspect(InspectOptions options,
                         BooleanCallback callback);
 
-    // Enable / Disable file access for a given |itemId|
-    static void allowFileAccess(DOMString itemId,
-                                boolean isAllow,
+    // Enable / Disable file access for a given |item_id|

[miket_OOO, 2013/01/09 18:52:41]

Hmmmm. These changes seem to go in the wrong style direction. Were they
necessary for some reason?

[Gaurav, 2013/01/12 01:08:26]

Did them to be consistent with enums. Should I revert them ?
On 2013/01/09 18:52:41, miket wrote:

+    static void allowFileAccess(DOMString item_id,
+                                boolean is_allow,

[miket_OOO, 2013/01/09 18:52:41]

isAllowed sounds more natural (isEnabled below, too)

[Gaurav, 2013/01/12 01:08:26]

Done.

                                 BooleanCallback callback);
 
-    // Reloads a given item with |itemId|
-    static void reload(DOMString itemId, BooleanCallback callback);
+    // Reloads a given item with |item_id|
+    static void reload(DOMString item_id, BooleanCallback callback);
 
-    // Uninstalls a given item with |itemId|
-    static void uninstall(DOMString itemId, BooleanCallback callback);
+    // Uninstalls a given item with |item_id|
+    static void uninstall(DOMString item_id, BooleanCallback callback);
 
-    // Enable / Disable a given item with id |itemId|
-    static void enable(DOMString itemId,
-                       boolean isEnable,
+    // Enable / Disable a given item with id |item_id|
+    static void enable(DOMString item_id,
+                       boolean is_enable,
                        BooleanCallback callback);
 
-    // Load a user selected unpacked extension 
+    // Load a user selected unpacked item 
     static void loadUnpacked(BooleanCallback callback);
 
+    // Open Dialog to browse to an entry.
+    // |select_type| : The select type folder or file.
+    // |file_type| : Required file type.

[asargent_no_longer_on_chrome, 2013/01/09 00:48:05]

What are the legal values for this? Does this mean the file's extension, e.g.
".json"? 

[miket_OOO, 2013/01/09 18:52:41]

An example would be good if a full enumeration isn't practical.

[Gaurav, 2013/01/12 01:08:26]

Done.

[Gaurav, 2013/01/12 01:08:26]

Done.

+    // |callback| : called with selected item's path.
+    static void chooseItem(DOMString select_type,

[asargent_no_longer_on_chrome, 2013/01/09 00:48:05]

Nit: maybe "choosePath" would be a better name for this method?

Also, we should use an enum instead of a DOMString for |select_type|. (see some
of the other .idl files in this directory for examples)

[Gaurav, 2013/01/12 01:08:26]

Done.

+                           DOMString file_type,
+                           PathCallback callback);
+
+    // Pack an item with given |item_path| and |private_key_path|
+    // |callback| : called with the success result string.
+    static void packItem(DOMString item_path,

[asargent_no_longer_on_chrome, 2013/01/09 00:48:05]

nit: I assume you use the term 'item' here and elsewhere because this could be
either an app or an extension, right? It would be nice if we could come up with
something better than 'item' in such cases, because it's a pretty vague term
that could mean anything. 

So maybe "packDirectory" would be a better name for this method? And just "path"
or "directory_path" instead of "item_path"?

[Gaurav, 2013/01/12 01:08:26]

Done.

+                         DOMString private_key_path,
+                         long flags,
+                         PackCallback callback);
+
     // Gets translated strings.
     static void getStrings(GetStringsCallback callback);
   };
 
 };