Update hasVisibleContent() to include visibility of non-self-painting layers.

Source/core/paint/DeprecatedPaintLayer.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  *
  * Portions are Copyright (C) 1998 Netscape Communications Corporation.
  *
  * Other contributors:
  *   Robert O'Callahan <roc+@cs.cmu.edu>
  *   David Baron <dbaron@fas.harvard.edu>
  *   Christian Biesinger <cbiesinger@web.de>
  *   Randall Jesup <rjesup@wgate.com>
@@ skipping 576 matching lines @@
     mapRectToPaintBackingCoordinates(paintInvalidationContainer->layoutObject(), rect);
     return rect;
 }
 
 void DeprecatedPaintLayer::dirtyVisibleContentStatus()
 {
     compositor()->setNeedsUpdateDescendantDependentFlags();
     m_visibleContentStatusDirty = true;
     if (parent())
         parent()->dirtyAncestorChainVisibleDescendantStatus();
+    if (!isSelfPaintingLayer())
+        parent()->dirtyVisibleContentStatus();

[chrishtr, 2015/06/25 17:26:50]

compositing/contents-opaque/visibility-hidden.html exercises this code, because
the <nav> element in that test is a non-self-painting layer.

 }
 
 void DeprecatedPaintLayer::potentiallyDirtyVisibleContentStatus(EVisibility visibility)
 {
     if (m_visibleContentStatusDirty)
         return;
     if (hasVisibleContent() == (visibility == VISIBLE))
         return;
     dirtyVisibleContentStatus();
 }
@@ skipping 50 matching lines @@
 
     if (m_visibleContentStatusDirty) {
         bool previouslyHasVisibleContent = m_hasVisibleContent;
         if (layoutObject()->style()->visibility() == VISIBLE) {
             m_hasVisibleContent = true;
         } else {
             // layer may be hidden but still have some visible content, check for this
             m_hasVisibleContent = false;
             LayoutObject* r = layoutObject()->slowFirstChild();
             while (r) {
-                if (r->style()->visibility() == VISIBLE && !r->hasLayer()) {
+                if (r->style()->visibility() == VISIBLE && (!r->hasLayer() || !r->enclosingLayer()->isSelfPaintingLayer())) {
                     m_hasVisibleContent = true;
                     break;
                 }
                 LayoutObject* layoutObjectFirstChild = r->slowFirstChild();
-                if (layoutObjectFirstChild && !r->hasLayer()) {
+                if (layoutObjectFirstChild && (!r->hasLayer() || !r->enclosingLayer()->isSelfPaintingLayer())) {
                     r = layoutObjectFirstChild;
                 } else if (r->nextSibling()) {
                     r = r->nextSibling();
                 } else {
                     do {
                         r = r->parent();
                         if (r == layoutObject())
                             r = 0;
                     } while (r && !r->nextSibling());
                     if (r)
@@ skipping 460 matching lines @@
     if (!child->stackingNode()->isTreatedAsStackingContextForPainting())
         m_stackingNode->dirtyNormalFlowList();
 
     if (child->stackingNode()->isTreatedAsStackingContextForPainting() || child->firstChild()) {
         // Dirty the z-order list in which we are contained. The ancestorStackingContextNode() can be null in the
         // case where we're building up generated content layers. This is ok, since the lists will start
         // off dirty in that case anyway.
         child->stackingNode()->dirtyStackingContextZOrderLists();
     }
 
+    // Non-self-painting children paint into this layer, so the visible contents status of this layer is affected.
+    if (!child->isSelfPaintingLayer())
+        dirtyVisibleContentStatus();
+
     dirtyAncestorChainVisibleDescendantStatus();
     dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
 
     child->updateDescendantDependentFlags();
 }
 
 DeprecatedPaintLayer* DeprecatedPaintLayer::removeChild(DeprecatedPaintLayer* oldChild)
 {
     if (oldChild->previousSibling())
         oldChild->previousSibling()->setNextSibling(oldChild->nextSibling());
@@ skipping 1577 matching lines @@
 
 void showLayerTree(const blink::LayoutObject* layoutObject)
 {
     if (!layoutObject) {
         fprintf(stderr, "Cannot showLayerTree. Root is (nil)\n");
         return;
     }
     showLayerTree(layoutObject->enclosingLayer());
 }
 #endif