Issue 11794029: GTTF: Enable debugallocation by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11794029: GTTF: Enable debugallocation by default. (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.

Modified:
7 years, 11 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, erikwright+watch_chromium.org, dmikurube+memory_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

GTTF: Enable debugallocation by default. TBR=willchan BUG=30715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175915

Patch Set 1 #

Patch Set 2 : uninitialized variables #

Patch Set 3 : fixes #

Patch Set 4 : rebase #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/allocator/allocator.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

TBR, just flipping a flag and part of previously reviewed CL

7 years, 11 months ago (2013-01-09 23:18:39 UTC) #1

willchan no longer on Chromium

7 years, 11 months ago (2013-01-16 00:00:35 UTC) #2

lgtm

On Wed, Jan 9, 2013 at 3:18 PM,  <phajdan.jr@chromium.org> wrote:
> Reviewers: willchan,
>
> Message:
> TBR, just flipping a flag and part of previously reviewed CL
>
> Description:
> GTTF: Enable debugallocation by default.
>
> TBR=willchan
>
> BUG=30715
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175915
>
> Please review this at https://codereview.chromium.org/11794029/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M base/allocator/allocator.gyp
>
>
> Index: base/allocator/allocator.gyp
> diff --git a/base/allocator/allocator.gyp b/base/allocator/allocator.gyp
> index
>
f5bda7370c1b5decbe6fa05eb5a77f51a5fc9543..e177fb8d6f568ccee6b3ae94ecbe3ae98de00d32
> 100644
> --- a/base/allocator/allocator.gyp
> +++ b/base/allocator/allocator.gyp
> @@ -312,7 +312,7 @@
>              # Provide a way to force disable debugallocation in Debug
> builds,
>              # e.g. for profiling (it's more rare to profile Debug builds,
>              # but people sometimes need to do that).
> -            'disable_debugallocation%': 1,
> +            'disable_debugallocation%': 0,
>            },
>            'conditions': [
>              ['disable_debugallocation==0', {
>
>

Expand Messages | Collapse Messages