Tweak comments and put in tests for ignoring safe browsing results.

content/browser/download/download_item_impl.cc

Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index 042934d69b2773850c9b81a3c04a1792c56cc669..9ff779465b48fc1d29f464bf88475486ca6e5481 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -591,15 +591,10 @@ DownloadItem::SafetyState DownloadItemImpl::GetSafetyState() const {
 bool DownloadItemImpl::IsDangerous() const {
   // TODO(noelutz): At this point only the windows views UI supports
   // warnings based on dangerous content.
-#ifdef OS_WIN

[asanka, 2013/01/07 17:14:31]

Why this change? The UI code for non-views doesn't reliably handle a transition
from non-dangerous -> dangerous.

[Randy Smith (Not in Mondays), 2013/01/07 20:55:59]

I'd rather not have the set danger test be windows only, and this ifdef didn't
strike me as having any meaning in non-test code since there's no way that we
can see *_CONTENT errors on non windows.  But I think my test will work (in unit
test mode) if I just set the new type to be DANGEROUS_FILE, so I'll try doing
that and reverting this change.

   return (danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_URL ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT);
-#else
-  return (danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE ||
-          danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_URL);
-#endif
 }
 
 DownloadDangerType DownloadItemImpl::GetDangerType() const {