Tweak comments and put in tests for ignoring safe browsing results.

Tweak comments and put in tests for not ignoring safe browsing results.

This is a follow-on CL to https://chromiumcodereview.appspot.com/11740026.

R=asanka@chromium.org

BUG=164777
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175565

[Randy Smith (Not in Mondays), 2013-01-05 22:08:58]

Asanka: PTAL?

[asanka, 2013-01-07 17:14:28]

https://codereview.chromium.org/11794016/diff/1/content/browser/download/down...
File content/browser/download/download_item_impl.cc (left):

https://codereview.chromium.org/11794016/diff/1/content/browser/download/down...
content/browser/download/download_item_impl.cc:594: #ifdef OS_WIN
Why this change? The UI code for non-views doesn't reliably handle a transition
from non-dangerous -> dangerous.

[Randy Smith (Not in Mondays), 2013-01-07 20:55:59]

PTAL.

https://codereview.chromium.org/11794016/diff/1/content/browser/download/down...
File content/browser/download/download_item_impl.cc (left):

https://codereview.chromium.org/11794016/diff/1/content/browser/download/down...
content/browser/download/download_item_impl.cc:594: #ifdef OS_WIN
On 2013/01/07 17:14:31, asanka wrote:
> Why this change? The UI code for non-views doesn't reliably handle a
transition
> from non-dangerous -> dangerous.

I'd rather not have the set danger test be windows only, and this ifdef didn't
strike me as having any meaning in non-test code since there's no way that we
can see *_CONTENT errors on non windows.  But I think my test will work (in unit
test mode) if I just set the new type to be DANGEROUS_FILE, so I'll try doing
that and reverting this change.

[asanka, 2013-01-07 21:00:10]

LGTM

[commit-bot: I haz the power, 2013-01-07 21:16:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/11794016/5001

[commit-bot: I haz the power, 2013-01-07 22:38:34]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-08 14:06:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/11794016/5001

[commit-bot: I haz the power, 2013-01-08 18:45:38]

Change committed as 175565