[turbofan] Enable concurrent (re)compilation.

src/compiler.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler.h"
 
 #include <algorithm>
 
 #include "src/ast-numbering.h"
 #include "src/bootstrapper.h"
@@ skipping 313 matching lines @@
 
 #define DEF_VISIT(type)                        \
   void Visit##type(type* node) override {      \
     HOptimizedGraphBuilder::Visit##type(node); \
   }
   DECLARATION_NODE_LIST(DEF_VISIT)
 #undef DEF_VISIT
 };
 
 
+OptimizedCompileJob::~OptimizedCompileJob() { delete pipeline_; }
+
+
 OptimizedCompileJob::Status OptimizedCompileJob::CreateGraph() {
   DCHECK(info()->IsOptimizing());
   DCHECK(!info()->IsCompilingForDebugging());
 
   // Do not use Crankshaft/TurboFan if we need to be able to set break points.
   if (isolate()->debug()->has_break_points()) {
     return RetryOptimization(kDebuggerHasBreakPoints);
   }
 
   // Limit the number of times we try to optimize functions.
@@ skipping 49 matching lines @@
     } else if (FLAG_turbo_type_feedback) {
       info()->MarkAsTypeFeedbackEnabled();
       info()->EnsureFeedbackVector();
     }
     if (!info()->shared_info()->asm_function() ||
         FLAG_turbo_asm_deoptimization) {
       info()->MarkAsDeoptimizationEnabled();
     }
 
     Timer t(this, &time_taken_to_create_graph_);
-    compiler::Pipeline pipeline(info());
-    pipeline.GenerateCode();
-    if (!info()->code().is_null()) {
+    pipeline_ = new compiler::Pipeline(info());
+    if (pipeline_->CreateGraph()) {
       return SetLastStatus(SUCCEEDED);
     }
+    delete pipeline_;
+    pipeline_ = nullptr;
   }
 
   if (!isolate()->use_crankshaft() || dont_crankshaft) {
     // Crankshaft is entirely disabled.
     return SetLastStatus(FAILED);
   }
 
   Scope* scope = info()->scope();
   if (LUnallocated::TooManyParameters(scope->num_parameters())) {
     // Crankshaft would require too many Lithium operands.
@@ skipping 57 matching lines @@
 }
 
 
 OptimizedCompileJob::Status OptimizedCompileJob::OptimizeGraph() {
   DisallowHeapAllocation no_allocation;
   DisallowHandleAllocation no_handles;
   DisallowHandleDereference no_deref;
   DisallowCodeDependencyChange no_dependency_change;
 
   DCHECK(last_status() == SUCCEEDED);
   // TODO(turbofan): Currently everything is done in the first phase.

[Michael Starzinger, 2015/06/16 12:23:01]

nit: TODO no longer applies, let's drop it.

[Benedikt Meurer, 2015/06/19 12:33:46]

Done.

-  if (!info()->code().is_null()) {
-    return last_status();
+  if (pipeline_) {

[Michael Starzinger, 2015/06/16 12:23:01]

Should we move this down a few lines so that it is covered by the below timer?

[Benedikt Meurer, 2015/06/19 12:33:46]

Done.

+    if (pipeline_->OptimizeGraph()) return SetLastStatus(SUCCEEDED);
+    return SetLastStatus(BAILED_OUT);
   }
 
   Timer t(this, &time_taken_to_optimize_);
   DCHECK(graph_ != NULL);
   BailoutReason bailout_reason = kNoReason;
 
   if (graph_->Optimize(&bailout_reason)) {
     chunk_ = LChunk::NewChunk(graph_);
     if (chunk_ != NULL) return SetLastStatus(SUCCEEDED);
   } else if (bailout_reason != kNoReason) {
     graph_builder_->Bailout(bailout_reason);
   }
 
   return SetLastStatus(BAILED_OUT);
 }
 
 
 OptimizedCompileJob::Status OptimizedCompileJob::GenerateCode() {
   DCHECK(last_status() == SUCCEEDED);
   // TODO(turbofan): Currently everything is done in the first phase.

[Michael Starzinger, 2015/06/16 12:23:01]

nit: TODO no longer applies, let's drop it.

[Benedikt Meurer, 2015/06/19 12:33:46]

Done.

-  if (!info()->code().is_null()) {
+  if (pipeline_) {
+    Handle<Code> optimized_code = pipeline_->CreateCode();

[Michael Starzinger, 2015/06/16 12:23:01]

This can now be intergrated into the code below, so that the call to
RecordOptimizationStats at the bottom is used. Also having this covered by the
three Disallow scopes below might be good.

[Benedikt Meurer, 2015/06/19 12:33:46]

Done.

+    if (optimized_code.is_null()) return SetLastStatus(BAILED_OUT);
+    DCHECK(optimized_code.is_identical_to(info()->code()));
     info()->dependencies()->Commit(info()->code());
     if (info()->is_deoptimization_enabled()) {
       info()->parse_info()->context()->native_context()->AddOptimizedCode(
           *info()->code());
     }
     RecordOptimizationStats();
-    return last_status();
+    return SetLastStatus(SUCCEEDED);
   }
 
   DCHECK(!info()->dependencies()->HasAborted());
   DisallowCodeDependencyChange no_dependency_change;
   DisallowJavascriptExecution no_js(isolate());
   {  // Scope for timer.
     Timer timer(this, &time_taken_to_codegen_);
     DCHECK(chunk_ != NULL);
     DCHECK(graph_ != NULL);
     // Deferred handles reference objects that were accessible during
@@ skipping 1042 matching lines @@
 
 
 #if DEBUG
 void CompilationInfo::PrintAstForTesting() {
   PrintF("--- Source from AST ---\n%s\n",
          PrettyPrinter(isolate(), zone()).PrintProgram(function()));
 }
 #endif
 }  // namespace internal
 }  // namespace v8