[turbofan] Enable concurrent (re)compilation.

[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org

Committed: https://crrev.com/ff19726d8045a11df0535d8cb9a51e8b7a35c5cc
Cr-Commit-Position: refs/heads/master@{#35818}

[Benedikt Meurer, 2015-06-16 11:36:37]

Hey Michi,

This is the first attempt. Please take a look.

Thanks,
Benedikt

[Michael Starzinger, 2015-06-16 12:23:02]

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode489
src/compiler.cc:489: // TODO(turbofan): Currently everything is done in the
first phase.
nit: TODO no longer applies, let's drop it.

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode490
src/compiler.cc:490: if (pipeline_) {
Should we move this down a few lines so that it is covered by the below timer?

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode512
src/compiler.cc:512: // TODO(turbofan): Currently everything is done in the
first phase.
nit: TODO no longer applies, let's drop it.

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode514
src/compiler.cc:514: Handle<Code> optimized_code = pipeline_->CreateCode();
This can now be intergrated into the code below, so that the call to
RecordOptimizationStats at the bottom is used. Also having this covered by the
three Disallow scopes below might be good.

[Benedikt Meurer, 2015-06-19 12:33:47]

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc
File src/compiler.cc (right):

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode489
src/compiler.cc:489: // TODO(turbofan): Currently everything is done in the
first phase.
On 2015/06/16 12:23:01, Michael Starzinger wrote:
> nit: TODO no longer applies, let's drop it.

Done.

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode490
src/compiler.cc:490: if (pipeline_) {
On 2015/06/16 12:23:01, Michael Starzinger wrote:
> Should we move this down a few lines so that it is covered by the below timer?

Done.

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode512
src/compiler.cc:512: // TODO(turbofan): Currently everything is done in the
first phase.
On 2015/06/16 12:23:01, Michael Starzinger wrote:
> nit: TODO no longer applies, let's drop it.

Done.

https://codereview.chromium.org/1179393008/diff/40001/src/compiler.cc#newcode514
src/compiler.cc:514: Handle<Code> optimized_code = pipeline_->CreateCode();
On 2015/06/16 12:23:01, Michael Starzinger wrote:
> This can now be intergrated into the code below, so that the call to
> RecordOptimizationStats at the bottom is used. Also having this covered by the
> three Disallow scopes below might be good.

Done.

[Benedikt Meurer, 2015-06-19 12:42:54]

Comments addressed. Please take another look.

[Michael Starzinger, 2015-06-22 11:26:31]

LGTM. Ceterum censeo compiler.cc esse delendam.

https://codereview.chromium.org/1179393008/diff/160001/src/compiler/pipeline.h
File src/compiler/pipeline.h (right):

https://codereview.chromium.org/1179393008/diff/160001/src/compiler/pipeline....
src/compiler/pipeline.h:29: // Separate pipeline steps.
nit: Can we extend the comment explaining that these three steps amount to the
same work as GenerateCode, and also that they need to be called in order.

[Jarin, 2015-06-22 13:24:14]

jarin@chromium.org changed reviewers:
+ jarin@chromium.org

[Jarin, 2015-06-22 13:24:15]

lgtm.

[ahaas, 2016-04-27 11:07:40]

ahaas@chromium.org changed reviewers:
+ ahaas@chromium.org

[ahaas, 2016-04-27 11:07:41]

lgtm

[ahaas, 2016-04-27 11:24:22]

https://codereview.chromium.org/1179393008/diff/200001/test/cctest/wasm/wasm-...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/1179393008/diff/200001/test/cctest/wasm/wasm-...
test/cctest/wasm/wasm-run-utils.h:489: Pipeline::NewWasmCompilationJob(&info,
graph(), descriptor(),
Use "desc" here instead of "descriptor()"

[Benedikt Meurer, 2016-04-27 11:25:54]

https://codereview.chromium.org/1179393008/diff/200001/test/cctest/wasm/wasm-...
File test/cctest/wasm/wasm-run-utils.h (right):

https://codereview.chromium.org/1179393008/diff/200001/test/cctest/wasm/wasm-...
test/cctest/wasm/wasm-run-utils.h:489: Pipeline::NewWasmCompilationJob(&info,
graph(), descriptor(),
Ah thanks, I was hunting that bug :-)

[Benedikt Meurer, 2016-04-27 11:26:11]

Description was changed from

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org
==========

to

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org
==========

[Michael Starzinger, 2016-04-27 11:56:59]

LGTM on the new version as well.

[Benedikt Meurer, 2016-04-27 12:13:42]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-04-27 12:13:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jarin@chromium.org,
ahaas@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1179393008/#ps240001
(title: "Fix debug name computation.")

[commit-bot: I haz the power, 2016-04-27 12:13:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1179393008/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1179393008/240001

[commit-bot: I haz the power, 2016-04-27 12:38:26]

Description was changed from

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org
==========

to

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org
==========

[commit-bot: I haz the power, 2016-04-27 12:38:27]

Committed patchset #13 (id:240001)

[commit-bot: I haz the power, 2016-04-27 12:40:13]

Description was changed from

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org
==========

to

==========
[turbofan] Enable concurrent (re)compilation.

Refactor the TurboFan pipeline to allow for concurrent recompilation in
the same way that Crankshaft does it. For now we limit the concurrent
phases to scheduling, instruction selection, register allocation and
jump threading.

R=mstarzinger@chromium.org, ahaas@chromium.org, jarin@chromium.org

Committed: https://crrev.com/ff19726d8045a11df0535d8cb9a51e8b7a35c5cc
Cr-Commit-Position: refs/heads/master@{#35818}
==========

[commit-bot: I haz the power, 2016-04-27 12:40:15]

Patchset 13 (id:??) landed as
https://crrev.com/ff19726d8045a11df0535d8cb9a51e8b7a35c5cc
Cr-Commit-Position: refs/heads/master@{#35818}