build/config/compiler/BUILD.gn - Issue 1179393004: Fix some build symbol configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1179393004: Fix some build symbol configuration. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 3930c79765d18a00abdad07a9808c5137ccc47a1..250933434660877cbc77cd311d14daaf5d4b4755 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -51,8 +51,8 @@ declare_args() {

# with some utilities such as icecc and ccache. Requires gold and

# gcc >= 4.8 or clang.

# http://gcc.gnu.org/wiki/DebugFission

- use_debug_fission =

- !is_win && use_gold && linux_use_bundled_binutils && !use_ccache

+ use_debug_fission = is_debug && !is_win && use_gold &&

+ linux_use_bundled_binutils && !use_ccache

if (is_win) {

# Whether the VS xtree header has been patched to disable warning 4702. If

« no previous file with comments | « build/common.gypi ('k') | build/linux/dump_app_syms » ('j') | no next file with comments »