Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1179373004: Add DOMSharedArrayBuffer type (Closed)

Created:
5 years, 6 months ago by binji
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add DOMSharedArrayBuffer type BUG=497295 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198334

Patch Set 1 #

Patch Set 2 : merge master #

Patch Set 3 : merge wtf ArrayBuffer change #

Patch Set 4 : . #

Total comments: 4

Patch Set 5 : feedback #

Patch Set 6 : merge master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -44 lines) Patch
M Source/core/core.gypi View 1 2 3 4 5 3 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/DOMArrayBuffer.h View 3 chunks +3 lines, -13 lines 0 comments Download
M Source/core/dom/DOMArrayBuffer.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
A Source/core/dom/DOMArrayBufferBase.h View 1 chunk +54 lines, -0 lines 0 comments Download
M Source/core/dom/DOMArrayBufferView.h View 5 chunks +25 lines, -4 lines 0 comments Download
M Source/core/dom/DOMDataView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/DOMDataView.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
A Source/core/dom/DOMSharedArrayBuffer.h View 1 chunk +48 lines, -0 lines 0 comments Download
A + Source/core/dom/DOMSharedArrayBuffer.cpp View 1 2 3 4 2 chunks +7 lines, -10 lines 0 comments Download
M Source/core/dom/DOMTypedArray.h View 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/dom/DOMTypedArray.cpp View 1 1 chunk +10 lines, -4 lines 0 comments Download
A + Source/core/dom/SharedArrayBuffer.idl View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
binji
Split from https://codereview.chromium.org/1097773004. PTAL
5 years, 5 months ago (2015-06-30 16:12:46 UTC) #2
haraken
LGTM https://codereview.chromium.org/1179373004/diff/60001/Source/core/dom/DOMSharedArrayBuffer.cpp File Source/core/dom/DOMSharedArrayBuffer.cpp (right): https://codereview.chromium.org/1179373004/diff/60001/Source/core/dom/DOMSharedArrayBuffer.cpp#newcode1 Source/core/dom/DOMSharedArrayBuffer.cpp:1: // Copyright 2014 The Chromium Authors. All rights ...
5 years, 5 months ago (2015-07-01 00:16:09 UTC) #3
binji
https://codereview.chromium.org/1179373004/diff/60001/Source/core/dom/DOMSharedArrayBuffer.cpp File Source/core/dom/DOMSharedArrayBuffer.cpp (right): https://codereview.chromium.org/1179373004/diff/60001/Source/core/dom/DOMSharedArrayBuffer.cpp#newcode1 Source/core/dom/DOMSharedArrayBuffer.cpp:1: // Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 5 months ago (2015-07-01 16:25:51 UTC) #4
haraken
Still LGTM
5 years, 5 months ago (2015-07-02 01:11:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179373004/100001
5 years, 5 months ago (2015-07-06 18:04:24 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 19:28:40 UTC) #9
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198334

Powered by Google App Engine
This is Rietveld 408576698